commit bb4cd2c027e18b4d67cff1b5f251872dfbd04c82
Author: Tom Hughes <tom@compton.nu>
Date: Tue Oct 27 10:33:35 2015 +0000
Ignore any errors from test requests
Calling end causes the request to proceed, which may they lead
to an exception being fired long after the test has seemingly
completed if there is any kind of network problem.
These exceptions seem to get hidden by older versions of vows but
newer ones manage to trap them and treat them as a failure.
diff --git a/package.json b/package.json
index 1a55533..405b635 100644
--- a/package.json
+++ b/package.json
@@ -6,7 +6,7 @@
, "author" : "Ciaran Jessup <ciaranj@gmail.com>"
, "repository" : { "type":"git", "url":"http://github.com/ciaranj/node-oauth.git" }
, "devDependencies": {
- "vows": "0.5.x"
+ "vows": "^0.8.1"
}
, "scripts": {
"test": "make test"
diff --git a/tests/oauthtests.js b/tests/oauthtests.js
index d36bfed..855f92d 100644
--- a/tests/oauthtests.js
+++ b/tests/oauthtests.js
@@ -333,6 +333,7 @@ vows.describe('OAuth').addBatch({
var request= oa.post("http://foo.com/blah", "token", "token_secret", "BLAH", "text/plain")
assert.isObject(request);
assert.equal(request.method, "POST");
+ request.on("error", function (r) {});
request.end();
}
},
@@ -525,6 +526,7 @@ vows.describe('OAuth').addBatch({
var request= oa.get("http://foo.com/blah", "token", "token_secret")
assert.isObject(request);
assert.equal(request.method, "GET");
+ request.on("error", function (r) {});
request.end();
}
},
@@ -557,6 +559,7 @@ vows.describe('OAuth').addBatch({
var request= oa.put("http://foo.com/blah", "token", "token_secret", "BLAH", "text/plain")
assert.isObject(request);
assert.equal(request.method, "PUT");
+ request.on("error", function (r) {});
request.end();
}
},
@@ -712,6 +715,7 @@ vows.describe('OAuth').addBatch({
var request= oa.delete("http://foo.com/blah", "token", "token_secret")
assert.isObject(request);
assert.equal(request.method, "DELETE");
+ request.on("error", function (r) {});
request.end();
}
},