Blob Blame History Raw
From 1d770b0d655cb20dfd093f012eaef72b2efe07fa Mon Sep 17 00:00:00 2001
From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 23 Apr 2009 00:28:54 +0200
Subject: [PATCH] don't claim we would know what reallocated-event-count actually is

We don't reliably know what this actually is on many drives and since it
is redundant to reallocated-sectors-count it's no loss to admit that we
have no clue.

See rhbz #497107.
---
 atasmart.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/atasmart.c b/atasmart.c
index 053cb88..8b44aa4 100644
--- a/atasmart.c
+++ b/atasmart.c
@@ -1165,14 +1165,14 @@ static const SkSmartAttributeInfo const attribute_info[256] = {
         [193] = { "load-cycle-count",            SK_SMART_ATTRIBUTE_UNIT_NONE },
         [194] = { "temperature-celsius-2",       SK_SMART_ATTRIBUTE_UNIT_MKELVIN },
         [195] = { "hardware-ecc-recovered",      SK_SMART_ATTRIBUTE_UNIT_NONE },
-        [196] = { "reallocated-event-count",     SK_SMART_ATTRIBUTE_UNIT_SECTORS },
+        [196] = { "reallocated-event-count",     SK_SMART_ATTRIBUTE_UNIT_NONE },
         [197] = { "current-pending-sector",      SK_SMART_ATTRIBUTE_UNIT_SECTORS },
         [198] = { "offline-uncorrectable",       SK_SMART_ATTRIBUTE_UNIT_SECTORS },
         [199] = { "udma-crc-error-count",        SK_SMART_ATTRIBUTE_UNIT_NONE },
         [200] = { "multi-zone-error-rate",       SK_SMART_ATTRIBUTE_UNIT_NONE },
         [201] = { "soft-read-error-rate",        SK_SMART_ATTRIBUTE_UNIT_NONE },
         [202] = { "ta-increase-count",           SK_SMART_ATTRIBUTE_UNIT_NONE },
-        [203] = { "run-out-cancel",              SK_SMART_ATTRIBUTE_UNIT_NONE },
+        [203] = { "run-out-cancel",              SK_SMART_ATTRIBUTE_UNIT_UNKNOWN },
         [204] = { "shock-count-write-open",      SK_SMART_ATTRIBUTE_UNIT_NONE },
         [205] = { "shock-rate-write-open",       SK_SMART_ATTRIBUTE_UNIT_NONE },
         [206] = { "flying-height",               SK_SMART_ATTRIBUTE_UNIT_UNKNOWN },
@@ -1665,7 +1665,6 @@ int sk_disk_smart_parse_attributes(SkDisk *d, SkSmartAttributeParseCallback cb,
 
                 /* Handle a few fields specially */
                 if ((!strcmp(a.name, "reallocated-sector-count") ||
-                     !strcmp(a.name, "reallocated-event-count") ||
                      !strcmp(a.name, "current-pending-sector")) &&
                     a.pretty_unit == SK_SMART_ATTRIBUTE_UNIT_SECTORS &&
                     a.pretty_value > 0) {
-- 
1.6.2.2