From 2afa4f20ef31525b9cd4c1beef931958d5a173a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
Date: Wed, 30 Mar 2016 10:13:19 +0200
Subject: [PATCH] Remove unused rcsid
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Buildig with GCC 6 fails:
gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -I. -Ixtalk -Wall -Werror -c -o astribank_usb.o astribank_usb.c
dahdi_registration syntax OK
astribank_usb.c:37:19: error: 'rcsid' defined but not used [-Werror=unused-const-variable]
static const char rcsid[] = "$Id$";
^~~~~
Upstream already removed the rcsid variables in commit:
commit f105a09eda3a3b832078194e7ece902271a8d7b7
Author: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
Date: Tue Jan 26 15:12:30 2016 +0200
Remove rcsid: Unused since move to Git
* While technically Git can support $ID keywords, in practice they are not
used.
* GCC now give a warning about ''rcsid' defined but not used' for some
of those.
Let's just remove the unused rcsid.
<https://bugzilla.redhat.com/show_bug.cgi?id=1306634>
Signed-off-by: Petr Písař <ppisar@redhat.com>
---
xpp/astribank_allow.c | 2 --
xpp/astribank_usb.c | 2 --
xpp/hexfile.c | 2 --
xpp/mpptalk.c | 2 --
4 files changed, 8 deletions(-)
diff --git a/xpp/astribank_allow.c b/xpp/astribank_allow.c
index 8f1ea92..dfffcac 100644
--- a/xpp/astribank_allow.c
+++ b/xpp/astribank_allow.c
@@ -36,8 +36,6 @@
#include <debug.h>
#include "astribank_license.h"
-static const char rcsid[] = "$Id$";
-
#define DBG_MASK 0x80
static char *progname;
diff --git a/xpp/astribank_usb.c b/xpp/astribank_usb.c
index af7e6aa..2d1f1a4 100644
--- a/xpp/astribank_usb.c
+++ b/xpp/astribank_usb.c
@@ -34,8 +34,6 @@
#include "astribank_usb.h"
#include <debug.h>
-static const char rcsid[] = "$Id$";
-
#define DBG_MASK 0x01
#define TIMEOUT 500
diff --git a/xpp/hexfile.c b/xpp/hexfile.c
index 1227b26..2a54fd5 100644
--- a/xpp/hexfile.c
+++ b/xpp/hexfile.c
@@ -28,8 +28,6 @@
#include <ctype.h>
#include "hexfile.h"
-static const char rcsid[] = "$Id$";
-
static parse_hexfile_report_func_t report_func = NULL;
parse_hexfile_report_func_t parse_hexfile_set_reporting(parse_hexfile_report_func_t rf)
diff --git a/xpp/mpptalk.c b/xpp/mpptalk.c
index 9bab867..db0b7ec 100644
--- a/xpp/mpptalk.c
+++ b/xpp/mpptalk.c
@@ -34,8 +34,6 @@
#include <xusb.h>
#include <xtalk.h>
-static const char rcsid[] = "$Id$";
-
#define DBG_MASK 0x02
const char *ack_status_msg(uint8_t status)
--
2.5.5