Blame 0001-Fix-for-issues-found-by-Coverity.patch
|
 |
c2be30f |
From 3c93c96eb6ea2abd3869921ee4c89e1a4d9e4c44 Mon Sep 17 00:00:00 2001
|
|
|
c2be30f |
From: Sumit Bose <sbose@redhat.com>
|
|
|
c2be30f |
Date: Tue, 14 Aug 2018 13:08:52 +0200
|
|
|
c2be30f |
Subject: [PATCH] Fix for issues found by Coverity
|
|
|
c2be30f |
|
|
|
c2be30f |
---
|
|
|
c2be30f |
library/adenroll.c | 12 ++++++------
|
|
|
c2be30f |
1 file changed, 6 insertions(+), 6 deletions(-)
|
|
|
c2be30f |
|
|
|
c2be30f |
diff --git a/library/adenroll.c b/library/adenroll.c
|
|
|
c2be30f |
index 02bd9e3..de2242a 100644
|
|
|
c2be30f |
--- a/library/adenroll.c
|
|
|
c2be30f |
+++ b/library/adenroll.c
|
|
|
c2be30f |
@@ -1575,7 +1575,7 @@ load_host_keytab (adcli_enroll *enroll)
|
|
|
c2be30f |
}
|
|
|
c2be30f |
|
|
|
c2be30f |
krb5_free_context (k5);
|
|
|
c2be30f |
- return ADCLI_SUCCESS;
|
|
|
c2be30f |
+ return res;
|
|
|
c2be30f |
}
|
|
|
c2be30f |
|
|
|
c2be30f |
typedef struct {
|
|
|
c2be30f |
@@ -1756,12 +1756,12 @@ add_principal_to_keytab (adcli_enroll *enroll,
|
|
|
c2be30f |
enroll->kvno, &password, enctypes, &salts[*which_salt]);
|
|
|
c2be30f |
|
|
|
c2be30f |
free_principal_salts (k5, salts);
|
|
|
c2be30f |
+ }
|
|
|
c2be30f |
|
|
|
c2be30f |
- if (code != 0) {
|
|
|
c2be30f |
- _adcli_err ("Couldn't add keytab entries: %s: %s",
|
|
|
c2be30f |
- enroll->keytab_name, krb5_get_error_message (k5, code));
|
|
|
c2be30f |
- return ADCLI_ERR_FAIL;
|
|
|
c2be30f |
- }
|
|
|
c2be30f |
+ if (code != 0) {
|
|
|
c2be30f |
+ _adcli_err ("Couldn't add keytab entries: %s: %s",
|
|
|
c2be30f |
+ enroll->keytab_name, krb5_get_error_message (k5, code));
|
|
|
c2be30f |
+ return ADCLI_ERR_FAIL;
|
|
|
c2be30f |
}
|
|
|
c2be30f |
|
|
|
c2be30f |
|
|
|
c2be30f |
--
|
|
|
c2be30f |
2.20.1
|
|
|
c2be30f |
|