From 3c93c96eb6ea2abd3869921ee4c89e1a4d9e4c44 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Tue, 14 Aug 2018 13:08:52 +0200 Subject: [PATCH] Fix for issues found by Coverity --- library/adenroll.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/library/adenroll.c b/library/adenroll.c index 02bd9e3..de2242a 100644 --- a/library/adenroll.c +++ b/library/adenroll.c @@ -1575,7 +1575,7 @@ load_host_keytab (adcli_enroll *enroll) } krb5_free_context (k5); - return ADCLI_SUCCESS; + return res; } typedef struct { @@ -1756,12 +1756,12 @@ add_principal_to_keytab (adcli_enroll *enroll, enroll->kvno, &password, enctypes, &salts[*which_salt]); free_principal_salts (k5, salts); + } - if (code != 0) { - _adcli_err ("Couldn't add keytab entries: %s: %s", - enroll->keytab_name, krb5_get_error_message (k5, code)); - return ADCLI_ERR_FAIL; - } + if (code != 0) { + _adcli_err ("Couldn't add keytab entries: %s: %s", + enroll->keytab_name, krb5_get_error_message (k5, code)); + return ADCLI_ERR_FAIL; } -- 2.20.1