maha / rpms / python-stem

Forked from rpms/python-stem 5 years ago
Clone
Blob Blame History Raw
From 6c677b6a4080d14a56d2d88ab2ddd9766cc60b9a Mon Sep 17 00:00:00 2001
From: Damian Johnson <atagar@torproject.org>
Date: Wed, 11 Jul 2018 09:05:32 -0700
Subject: 'async' SyntaxError with python 3.6 and above

Python 3.6 adds a couple new keywords to the language (async and await) so we
need to be careful not to use those. 99.9% of our users don't import our test
utils so this was mostly moot, but Juan ran into an issue packaging Stem for
Fedora...

  BUILDSTDERR:   File "/usr/lib/python3.7/site-packages/stem/util/test_tools.py", line 151
  BUILDSTDERR:     self.method.async = self
  BUILDSTDERR:                     ^
  BUILDSTDERR: SyntaxError: invalid syntax

  https://trac.torproject.org/projects/tor/ticket/26739

This line aimed to provide a way for tests to reference its AsyncTest instance.
This doesn't look to actually be used in practice so think we can simply drop
it. Checked with grep and a 'run_tests.py --all --target ONLINE' run.
---
 docs/change_log.rst     | 1 +
 stem/util/test_tools.py | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/stem/util/test_tools.py b/stem/util/test_tools.py
index 722398d..c757320 100644
--- a/stem/util/test_tools.py
+++ b/stem/util/test_tools.py
@@ -148,7 +148,6 @@ class AsyncTest(object):
     self._threaded = threaded
 
     self.method = lambda test: self.result(test)  # method that can be mixed into TestCases
-    self.method.async = self
 
     self._process = None
     self._process_pipe = None
-- 
cgit v1.1