#10 It is no longer needed to fetch Cython from git master
Merged 3 years ago by churchyard. Opened 3 years ago by churchyard.
tests/ churchyard/python py38cython_nomaster  into  master

file modified
+1 -4
@@ -35,10 +35,7 @@ 

      pip install Cython --install-option="--no-cython-compile"

  else

      python -m pip install pytest

-     if [ "$VERSION" == "3.8" ]; then

-         # Cython support for 3.8.0a4+ is not yet released

-         python -m pip install https://github.com/cython/cython/archive/master.tar.gz --install-option="--no-cython-compile"

-     elif [ "$PYTHON" != "jython" ]; then

+     if [ "$PYTHON" != "jython" ]; then

          # We try to fetch a wheel only and if that fails, we disable compilation

          # Useful for fresh CPythons, where wheels are not yet ready, but Cython defaults to compiling

          python -m pip install Cython --only-binary :all: || python -m pip install Cython --install-option="--no-cython-compile"

no initial comment

Shouldn't the [ "$VERSION" == "3.8" ] branch just be removed? (Or commented out, since it might be needed for 3.9?)

There's no Jython 3.8 in sight, so [ "$VERSION" == "3.8" ] || [ "$PYTHON" != "jython" ] looks unnecessary.

Oh, the code is wrong. The [ "$VERSION" == "3.8" ] should be removed, I've overlooked the ! mark in Jython and made a bad assumption.

rebased onto d72c62f

3 years ago

Don't know how to test, but the code looks good now!

Pull-Request has been merged by churchyard

3 years ago