PR#1: prevent segfault on certain drag-and-drop actions - rpms/xarchiver

Niels de Vos • 5 years ago

97263ba

xarchiver-0.5.4-dnd-segfault.patch

file added

+32

		`@@ -0,0 +1,32 @@`
		`+ From 43896debcea363d7dfa17290e9ed8462af0375a3 Mon Sep 17 00:00:00 2001`
		`+ From: =?UTF-8?q?Ingo=20Br=C3=BCckl?= <ib@wupperonline.de>`
		`+ Date: Mon, 22 Jun 2015 14:18:25 +0200`
		`+ Subject: [PATCH] Check XdndDirectSave property received from destination`
		`+`
		`+ According to the Direct Save Protocol (XDS) specifications`
		`+ the destination shall convert the XdndDirectSave property`
		`+ to a URL.`
		`+`
		`+ Check whether this has happened to avoid a segmentation fault.`
		`+`
		`+ Reported by vincent-t on github.`
		`+ ---`
		`+ src/window.c \| 2 ++`
		`+ 1 file changed, 2 insertions(+)`
		`+`
		`+ diff --git a/src/window.c b/src/window.c`
		`+ index 5ba616e..7bd6cbb 100644`
		`+ --- a/src/window.c`
		`+ +++ b/src/window.c`
		`+ @@ -1718,6 +1718,8 @@ void drag_data_get (GtkWidget widget,GdkDragContext dc,GtkSelectionData *selec`
		`+ destination = g_filename_from_uri((gchar*)_destination,NULL,NULL);`
		`+ g_free(_destination);`
		`+`
		`+ + if (!destination) return;`
		`+ +`
		`+ archive->extraction_path = xa_remove_level_from_path (destination);`
		`+ g_free(destination);`
		`+`
		`+ --`
		`+ 2.19.0`
		`+`

xarchiver.spec

file modified

+7 -1

		`@@ -1,6 +1,6 @@`
		`Name: xarchiver`
		`Version: 0.5.4`
		`- Release: 8%{?dist}`
		`+ Release: 9%{?dist}`
		`Summary: Archive manager for Xfce`

		`Group: Applications/Archiving`
		`@@ -9,6 +9,8 @@`
		`Source0: http://downloads.sourceforge.net/xarchiver/xarchiver-%{version}.tar.bz2`

		`Patch0: xarchiver-0.5.4-version-fix.patch`
		`+ # from github.com/ib/xarchiver/commit/43896debcea363d7dfa17290e9ed8462af0375a3`
		`+ Patch1: xarchiver-0.5.4-dnd-segfault.patch`

		`BuildRequires: gtk2-devel, libxml2-devel, gettext, desktop-file-utils`
		`BuildRequires: xfce4-dev-tools >= 4.3.90.2`
		`@@ -29,6 +31,7 @@`
		`%prep`
		`%setup -q`
		`%patch0 -p1`
		`+ %patch1 -p1`
		`# fix spurious executable permissions of some debug files`
		`chmod -x src/mime.*`

		`@@ -98,6 +101,9 @@`


		`%changelog`
		`+ * Thu Oct 04 2018 Niels de Vos <devos@fedoraproject.org> - 0.5.4-9`
		`+ - prevent segfault on certain drag-and-drop actions (#1635869)`
		`+`
		`* Sat Jul 14 2018 Fedora Release Engineering <releng@fedoraproject.org> - 0.5.4-8`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild`