Also:
- Set endorsed.dir property so xml-commons-apis.jar can be found during build
- Build with JDK 11
- Fix generate-tarball.sh to actually compress the tarball
On that last point, this is the 2nd Java package with a generate-tarball.sh file that I have touched. Both had the same bug: they name the generated tarball with a .tar.gz ending, but don't actually compress the tarball. I'm betting somebody copied this same script to a number of Java packages, and they all have the same bug. If there is an easy way to hunt down all generate-tarball.sh files, somebody should do so and fix them all.
I would also suggest that xz compression should be used instead of gz, but that's icing on the cake.
jjames
commented 3 years ago
Also:
- Set endorsed.dir property so xml-commons-apis.jar can be found during build
- Build with JDK 11
- Fix generate-tarball.sh to actually compress the tarball
On that last point, this is the 2nd Java package with a generate-tarball.sh file that I have touched. Both had the same bug: they name the generated tarball with a .tar.gz ending, but don't actually compress the tarball. I'm betting somebody copied this same script to a number of Java packages, and they all have the same bug. If there is an easy way to hunt down all generate-tarball.sh files, somebody should do so and fix them all.
I would also suggest that xz compression should be used instead of gz, but that's icing on the cake.