rpms / vim

Clone
Source Code
GIT

#2 Remove requirements for vim in Makefile beakerlib tests.
Merged 5 years ago by zdohnal. Opened 6 years ago by astepano.
rpms/ astepano/vim tests_pkg_req  into  master

file modified
-1 
@@ -54,7 +54,6 @@ 
 

  	@echo "Type:            Regression" >> $(METADATA)
 

  	@echo "TestTime:        5m" >> $(METADATA)
 

  	@echo "RunFor:          vim" >> $(METADATA)
 

- 	@echo "Requires:        vim" >> $(METADATA)
 

  	@echo "Priority:        Normal" >> $(METADATA)
 

  	@echo "License:         GPLv2" >> $(METADATA)
 

  	@echo "Confidential:    no" >> $(METADATA)

file modified
+1 -1 
@@ -54,7 +54,7 @@ 
 

  	@echo "Type:            Regression" >> $(METADATA)
 

  	@echo "TestTime:        5m" >> $(METADATA)
 

  	@echo "RunFor:          vim" >> $(METADATA)
 

- 	@echo "Requires:        vim vim-minimal" >> $(METADATA)
 

+ 	@echo "Requires:        vim-minimal" >> $(METADATA)
 

  	@echo "Priority:        Normal" >> $(METADATA)
 

  	@echo "License:         GPLv2" >> $(METADATA)
 

  	@echo "Confidential:    no" >> $(METADATA)

There are requirements for explicit vim-enhanced and vim-minimal.

Signed-off-by: Andrei Stepanov astepano@redhat.com

Hi,
can I reproduce the issue locally? Or how can I see if the fix solves the issue?

[citest] re-running the test for this pr on pipeline.

And would you mind telling me how to do it please?

if you add new comment with [citest] the pipeline will re-run. Also on rebase.

Damn... my bad - I copied bad link. I was talking about the run from your comment.

rebased onto 9647e2f
5 years ago

[citest]

[citest]

[citest]

@astepano pipeline still fails during package tests.
+ cat /workDir/workspace/fedora-rawhide-pr-pipeline/logs/test.log

cat: /workDir/workspace/fedora-rawhide-pr-pipeline/logs/test.log: No such file or directory

script returned exit code 1

there was an issue on pipeline, it should be fixed now. [citest]

Ok, I'll check it. [citest]

Pipeline test seems okay, I'll just try local run of tests now.

They ran smoothly too, merging. Thank you for the patch!

Commit ff57c0d fixes this pull-request

Pull-Request has been merged by zdohnal
5 years ago

Pull-Request has been merged by zdohnal
5 years ago
Changes Summary 2
+0 -1
file changed
tests/netrw-plugin-delete-command-broken/Makefile
+1 -1
file changed
tests/vim-in-ex-mode-incorrectly-gives-an-eol-error/Makefile
Powered by Pagure 5.14.1
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.