|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
To: vim_dev@googlegroups.com
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Subject: Patch 7.3.156
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Fcc: outbox
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
From: Bram Moolenaar <Bram@moolenaar.net>
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Mime-Version: 1.0
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Content-Type: text/plain; charset=UTF-8
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Content-Transfer-Encoding: 8bit
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
------------
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Patch 7.3.156
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Problem: Tty names possibly left unterminated.
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Solution: Use vim_strncpy() instead of strncpy().
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
Files: src/pty.c
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*** ../vim-7.3.155/src/pty.c 2010-08-15 21:57:28.000000000 +0200
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
--- src/pty.c 2011-04-11 14:02:49.000000000 +0200
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
***************
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*** 209,216 ****
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
#ifdef _SEQUENT_
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
fvhangup(s);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
#endif
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
! strncpy(PtyName, m, sizeof(PtyName));
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
! strncpy(TtyName, s, sizeof(TtyName));
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
initmaster(f);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*ttyn = TtyName;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
return f;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
--- 209,216 ----
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
#ifdef _SEQUENT_
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
fvhangup(s);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
#endif
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
! vim_strncpy((char_u *)PtyName, (char_u *)m, sizeof(PtyName) - 1);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
! vim_strncpy((char_u *)TtyName, (char_u *)s, sizeof(TtyName) - 1);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
initmaster(f);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*ttyn = TtyName;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
return f;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
***************
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*** 301,307 ****
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
return -1;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
}
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
signal(SIGCHLD, sigcld);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
! strncpy(TtyName, m, sizeof(TtyName));
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
initmaster(f);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*ttyn = TtyName;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
return f;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
--- 301,307 ----
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
return -1;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
}
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
signal(SIGCHLD, sigcld);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
! vim_strncpy((char_u *)TtyName, (char_u *)m, sizeof(TtyName) - 1);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
initmaster(f);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*ttyn = TtyName;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
return f;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
***************
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*** 326,332 ****
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
/* a dumb looking loop replaced by mycrofts code: */
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
if ((f = open("/dev/ptc", O_RDWR | O_NOCTTY | O_EXTRA)) < 0)
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
return -1;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
! strncpy(TtyName, ttyname(f), sizeof(TtyName));
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
if (geteuid() != ROOT_UID && mch_access(TtyName, R_OK | W_OK))
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
{
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
close(f);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
--- 326,332 ----
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
/* a dumb looking loop replaced by mycrofts code: */
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
if ((f = open("/dev/ptc", O_RDWR | O_NOCTTY | O_EXTRA)) < 0)
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
return -1;
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
! vim_strncpy((char_u *)TtyName, (char_u *)ttyname(f), sizeof(TtyName) - 1);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
if (geteuid() != ROOT_UID && mch_access(TtyName, R_OK | W_OK))
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
{
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
close(f);
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*** ../vim-7.3.155/src/version.c 2011-04-11 13:46:07.000000000 +0200
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
--- src/version.c 2011-04-11 14:23:38.000000000 +0200
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
***************
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
*** 716,717 ****
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
--- 716,719 ----
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
{ /* Add new patch number below this line */
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
+ /**/
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
+ 156,
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
/**/
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
--
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
I think that you'll agree that engineers are very effective in their social
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
interactions. It's the "normal" people who are nuts.
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
(Scott Adams - The Dilbert principle)
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
\\\ an exciting new programming language -- http://www.Zimbu.org ///
|
|
![](https://seccdn.libravatar.org/avatar/d9c2329ed86b5a3d16b53832d4e0af08aeacef0449836318546ae137799e4323?s=16&d=retro) |
5d1bb07 |
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|