d905bfa
To: vim-dev@vim.org
d905bfa
Subject: patch 7.1.113
d905bfa
Fcc: outbox
d905bfa
From: Bram Moolenaar <Bram@moolenaar.net>
d905bfa
Mime-Version: 1.0
d905bfa
Content-Type: text/plain; charset=ISO-8859-1
d905bfa
Content-Transfer-Encoding: 8bit
d905bfa
------------
d905bfa
d905bfa
Patch 7.1.113
d905bfa
Problem:    Using map() to go over an empty list causes memory to be freed
d905bfa
	    twice. (A.Politz)
d905bfa
Solution:   Don't clear the typeval in restore_vimvar().
d905bfa
Files:	    src/eval.c
d905bfa
d905bfa
d905bfa
*** ../vim-7.1.112/src/eval.c	Sun Sep 16 14:20:18 2007
d905bfa
--- src/eval.c	Sun Sep 16 19:24:49 2007
d905bfa
***************
d905bfa
*** 1318,1324 ****
d905bfa
  {
d905bfa
      hashitem_T	*hi;
d905bfa
  
d905bfa
-     clear_tv(&vimvars[idx].vv_tv);
d905bfa
      vimvars[idx].vv_tv = *save_tv;
d905bfa
      if (vimvars[idx].vv_type == VAR_UNKNOWN)
d905bfa
      {
d905bfa
--- 1318,1323 ----
d905bfa
***************
d905bfa
*** 1362,1368 ****
d905bfa
  
d905bfa
      if (p_verbose == 0)
d905bfa
  	--emsg_off;
d905bfa
-     vimvars[VV_VAL].vv_str = NULL;
d905bfa
      restore_vimvar(VV_VAL, &save_val);
d905bfa
  
d905bfa
      return list;
d905bfa
--- 1361,1366 ----
d905bfa
***************
d905bfa
*** 9387,9401 ****
d905bfa
  {
d905bfa
      typval_T	rettv;
d905bfa
      char_u	*s;
d905bfa
  
d905bfa
      copy_tv(tv, &vimvars[VV_VAL].vv_tv);
d905bfa
      s = expr;
d905bfa
      if (eval1(&s, &rettv, TRUE) == FAIL)
d905bfa
! 	return FAIL;
d905bfa
      if (*s != NUL)  /* check for trailing chars after expr */
d905bfa
      {
d905bfa
  	EMSG2(_(e_invexpr2), s);
d905bfa
! 	return FAIL;
d905bfa
      }
d905bfa
      if (map)
d905bfa
      {
d905bfa
--- 9386,9401 ----
d905bfa
  {
d905bfa
      typval_T	rettv;
d905bfa
      char_u	*s;
d905bfa
+     int		retval = FAIL;
d905bfa
  
d905bfa
      copy_tv(tv, &vimvars[VV_VAL].vv_tv);
d905bfa
      s = expr;
d905bfa
      if (eval1(&s, &rettv, TRUE) == FAIL)
d905bfa
! 	goto theend;
d905bfa
      if (*s != NUL)  /* check for trailing chars after expr */
d905bfa
      {
d905bfa
  	EMSG2(_(e_invexpr2), s);
d905bfa
! 	goto theend;
d905bfa
      }
d905bfa
      if (map)
d905bfa
      {
d905bfa
***************
d905bfa
*** 9414,9423 ****
d905bfa
  	/* On type error, nothing has been removed; return FAIL to stop the
d905bfa
  	 * loop.  The error message was given by get_tv_number_chk(). */
d905bfa
  	if (error)
d905bfa
! 	    return FAIL;
d905bfa
      }
d905bfa
      clear_tv(&vimvars[VV_VAL].vv_tv);
d905bfa
!     return OK;
d905bfa
  }
d905bfa
  
d905bfa
  /*
d905bfa
--- 9414,9425 ----
d905bfa
  	/* On type error, nothing has been removed; return FAIL to stop the
d905bfa
  	 * loop.  The error message was given by get_tv_number_chk(). */
d905bfa
  	if (error)
d905bfa
! 	    goto theend;
d905bfa
      }
d905bfa
+     retval = OK;
d905bfa
+ theend:
d905bfa
      clear_tv(&vimvars[VV_VAL].vv_tv);
d905bfa
!     return retval;
d905bfa
  }
d905bfa
  
d905bfa
  /*
d905bfa
*** ../vim-7.1.112/src/version.c	Sun Sep 16 14:20:18 2007
d905bfa
--- src/version.c	Mon Sep 17 21:33:52 2007
d905bfa
***************
d905bfa
*** 668,669 ****
d905bfa
--- 668,671 ----
d905bfa
  {   /* Add new patch number below this line */
d905bfa
+ /**/
d905bfa
+     113,
d905bfa
  /**/
d905bfa
d905bfa
-- 
d905bfa
Mental Floss prevents moral decay!
d905bfa
d905bfa
 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
d905bfa
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
d905bfa
\\\        download, build and distribute -- http://www.A-A-P.org        ///
d905bfa
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///