|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
From d3c91bc345f27a78d17c836f04fe13f5d1be6856 Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
From: Igor Lvovsky <ilvovsky@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
Date: Sun, 10 Jun 2012 10:40:48 +0300
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
Subject: [PATCH 15/17] BZ#830486 - Allow to change network according the diffs from previous state
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
We may not receive any information about the bonding device if it is unchanged.
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
In this case vdsm shouldn't check the bond information of this network.
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
Change-Id: I1ece66a351576d5789a8968ccda9e67f423b860c
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
Signed-off-by: Igor Lvovsky <ilvovsky@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
Reviewed-on: http://gerrit.ovirt.org/5211
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
Reviewed-by: Dan Kenigsberg <danken@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
Reviewed-on: http://gerrit.ovirt.org/5557
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
Tested-by: Federico Simoncelli <fsimonce@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
---
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
vdsm/configNetwork.py | 15 +++++++++------
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
1 files changed, 9 insertions(+), 6 deletions(-)
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
index fce3e71..ab07da6 100755
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
--- a/vdsm/configNetwork.py
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+++ b/vdsm/configNetwork.py
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
@@ -1085,12 +1085,15 @@ def setupNetworks(networks={}, bondings={}, **options):
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
d = dict(networkAttrs)
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
if 'bonding' in d:
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
- d['nics'] = bondings[d['bonding']]['nics']
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
- d['bondingOptions'] = bondings[d['bonding']].get('options',
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
- None)
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
- # Don't remove bondX from the bonding list here,
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
- # because it may be in use for other networks
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
- handledBonds.add(d['bonding'])
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ # we may not receive any information
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ # about the bonding device if it is unchanged
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ if bondings:
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ d['nics'] = bondings[d['bonding']]['nics']
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ d['bondingOptions'] = bondings[d['bonding']].get('options',
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ None)
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ # Don't remove bondX from the bonding list here,
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ # because it may be in use for other networks
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
+ handledBonds.add(d['bonding'])
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
else:
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
d['nics'] = [d.pop('nic')]
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
d['force'] = force
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
--
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
1.7.1
|
|
![](https://seccdn.libravatar.org/avatar/462a60e1d169ce7ce64da9fb6b067f5c020a5e963dfca570256adc87ec5450f2?s=16&d=retro) |
83b9f8f |
|