From b77212f16ccec520909169010fe8c463477e1901 Mon Sep 17 00:00:00 2001 From: Miloslav Trmač Date: Apr 24 2017 20:13:58 +0000 Subject: Fix a build failure with -Werror=format-security --- diff --git a/usermode-1.111-format-security.patch b/usermode-1.111-format-security.patch new file mode 100644 index 0000000..efd1c49 --- /dev/null +++ b/usermode-1.111-format-security.patch @@ -0,0 +1,21 @@ +commit b562472980ecd903d13e69279a31fcf77fac57bc +Author: Miloslav Trmač +Date: Mon Apr 24 21:58:56 2017 +0200 + + Don't unnecessarily use g_strdup_printf() + + This avoids a build failure with Werror=format-security. + +diff --git a/userhelper.c b/userhelper.c +index 15d2c5e..287aa4d 100644 +--- a/userhelper.c ++++ b/userhelper.c +@@ -583,7 +583,7 @@ converse_console(int num_msg, const struct pam_message **msg, + + if (banner == 0) { + if ((data->banner != NULL) && (data->domain != NULL)) { +- text = g_strdup_printf(dgettext(data->domain, data->banner)); ++ text = g_strdup (dgettext(data->domain, data->banner)); + } else { + if ((service != NULL) && (strlen(service) > 0)) { + if (data->fallback_allowed) { diff --git a/usermode.spec b/usermode.spec index 4dd811b..a376893 100644 --- a/usermode.spec +++ b/usermode.spec @@ -1,12 +1,14 @@ Summary: Tools for certain user account management tasks Name: usermode Version: 1.111 -Release: 9%{?dist} +Release: 10%{?dist} License: GPLv2+ Group: Applications/System URL: https://fedorahosted.org/usermode/ Source: https://fedorahosted.org/releases/u/s/usermode/usermode-%{version}.tar.xz Source1: config-util +# Upstream commit b562472980ecd903d13e69279a31fcf77fac57bc +Patch0: usermode-1.111-format-security.patch Requires: pam, passwd, util-linux BuildRequires: desktop-file-utils, gettext, glib2-devel, gtk2-devel, intltool BuildRequires: libblkid-devel, libSM-devel, libselinux-devel, libuser-devel @@ -38,6 +40,8 @@ graphical tools for certain account management tasks. %prep %setup -q +%patch0 -p1 -b .format-security + %build %configure --with-selinux @@ -90,6 +94,10 @@ done %{_datadir}/applications/* %changelog +* Mon Apr 24 2017 Miloslav Trmač - 1.111-10 +- Fix a FBFS with -Werror=format-security + Resolves #1444750 + * Sat Feb 11 2017 Fedora Release Engineering - 1.111-9 - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild