From cd42e13fb7cace15dade2c874275fe4b2f8ec4cf Mon Sep 17 00:00:00 2001
From: Vitezslav Crhonek <vcrhonek@redhat.com>
Date: Sep 10 2012 11:38:46 +0000
Subject: Fix issues found by fedora-review utility in the spec file


---

diff --git a/texinfo.spec b/texinfo.spec
index 7945075..7e4b251 100644
--- a/texinfo.spec
+++ b/texinfo.spec
@@ -1,9 +1,9 @@
-%define tex_texinfo %{_datadir}/texmf/tex/texinfo
+%global tex_texinfo %{_datadir}/texmf/tex/texinfo
 
 Summary: Tools needed to create Texinfo format documentation files
 Name: texinfo
 Version: 4.13a
-Release: 17%{?dist}
+Release: 18%{?dist}
 License: GPLv3+
 Group: Applications/Publishing
 Url: http://www.gnu.org/software/texinfo/
@@ -23,7 +23,6 @@ Patch5: texinfo-4.13a-texi2dvi-regexp.patch
 Patch6: texinfo-4.13a-makeinfo-sectioning.patch
 Requires(post): /sbin/install-info
 Requires(preun): /sbin/install-info
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires: zlib-devel, ncurses-devel, help2man
 
 %description
@@ -75,7 +74,6 @@ for printing using TeX.
 make %{?_smp_mflags}
 
 %install
-rm -rf ${RPM_BUILD_ROOT}
 mkdir -p ${RPM_BUILD_ROOT}/sbin
 
 make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
@@ -94,9 +92,6 @@ mv ChangeLog_utf8 ChangeLog
 
 %find_lang %name
 
-%clean
-rm -rf ${RPM_BUILD_ROOT}
-
 %post
 if [ -f %{_infodir}/texinfo.gz ]; then # --excludedocs?
     /sbin/install-info %{_infodir}/texinfo.gz %{_infodir}/dir || :
@@ -133,7 +128,6 @@ fi
 
 
 %files -f %{name}.lang
-%defattr(-,root,root,-)
 %doc AUTHORS ChangeLog INTRODUCTION NEWS README TODO COPYING
 %{_bindir}/makeinfo
 %{_datadir}/texinfo
@@ -142,7 +136,6 @@ fi
 %{_mandir}/man5/texinfo.5*
 
 %files -n info
-%defattr(-,root,root,-)
 %config(noreplace) %verify(not md5 size mtime) %{_infodir}/dir
 %doc COPYING
 %{_bindir}/info
@@ -156,7 +149,6 @@ fi
 %{_mandir}/man5/info.5*
 
 %files tex
-%defattr(-,root,root)
 %{_bindir}/texindex
 %{_bindir}/texi2dvi
 %{_bindir}/texi2pdf
@@ -168,6 +160,9 @@ fi
 %{_mandir}/man1/pdftexi2dvi.1*
 
 %changelog
+* Mon Sep 10 2012 Vitezslav Crhonek <vcrhonek@redhat.com> - 4.13a-18
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 4.13a-17
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild