Michal Ruprich e77f78c
diff -up netkit-telnet-0.17/telnetd/utility.c.orig netkit-telnet-0.17/telnetd/utility.c
Michal Ruprich e77f78c
--- netkit-telnet-0.17/telnetd/utility.c.orig	2020-03-25 11:53:56.772624325 +0100
Michal Ruprich e77f78c
+++ netkit-telnet-0.17/telnetd/utility.c	2020-03-25 11:54:01.966601415 +0100
Michal Ruprich e77f78c
@@ -221,31 +221,38 @@ void 	ptyflush(void)
Michal Ruprich e77f78c
  */
Michal Ruprich e77f78c
 static
Michal Ruprich e77f78c
 char *
Michal Ruprich e77f78c
-nextitem(char *current)
Michal Ruprich e77f78c
+nextitem(char *current, const char *endp)
Michal Ruprich e77f78c
 {
Michal Ruprich e77f78c
+    if (current >= endp) {
Michal Ruprich e77f78c
+        return NULL;
Michal Ruprich e77f78c
+    }
Michal Ruprich e77f78c
     if ((*current&0xff) != IAC) {
Michal Ruprich e77f78c
 	return current+1;
Michal Ruprich e77f78c
     }
Michal Ruprich e77f78c
+    if (current+1 >= endp) {
Michal Ruprich e77f78c
+        return NULL;
Michal Ruprich e77f78c
+    }
Michal Ruprich e77f78c
     switch (*(current+1)&0xff) {
Michal Ruprich e77f78c
     case DO:
Michal Ruprich e77f78c
     case DONT:
Michal Ruprich e77f78c
     case WILL:
Michal Ruprich e77f78c
     case WONT:
Michal Ruprich e77f78c
-	return current+3;
Michal Ruprich e77f78c
+	return current+3 <= endp ? current+3 : NULL;
Michal Ruprich e77f78c
     case SB:		/* loop forever looking for the SE */
Michal Ruprich e77f78c
 	{
Michal Ruprich e77f78c
 	    register char *look = current+2;
Michal Ruprich e77f78c
 
Michal Ruprich e77f78c
-	    for (;;) {
Michal Ruprich e77f78c
+	    while (look < endp) {
Michal Ruprich e77f78c
 		if ((*look++&0xff) == IAC) {
Michal Ruprich e77f78c
-		    if ((*look++&0xff) == SE) {
Michal Ruprich e77f78c
+		    if (look < endp && (*look++&0xff) == SE) {
Michal Ruprich e77f78c
 			return look;
Michal Ruprich e77f78c
 		    }
Michal Ruprich e77f78c
 		}
Michal Ruprich e77f78c
 	    }
Michal Ruprich e77f78c
+	    return NULL;
Michal Ruprich e77f78c
 	}
Michal Ruprich e77f78c
     default:
Michal Ruprich e77f78c
-	return current+2;
Michal Ruprich e77f78c
+	return current+2 <= endp ? current+2 : NULL;
Michal Ruprich e77f78c
     }
Michal Ruprich e77f78c
 }  /* end of nextitem */
Michal Ruprich e77f78c
 
Michal Ruprich e77f78c
@@ -271,7 +278,7 @@ void netclear(void)
Michal Ruprich e77f78c
     register char *thisitem, *next;
Michal Ruprich e77f78c
     char *good;
Michal Ruprich e77f78c
 #define	wewant(p)	((nfrontp > p) && ((*p&0xff) == IAC) && \
Michal Ruprich e77f78c
-				((*(p+1)&0xff) != EC) && ((*(p+1)&0xff) != EL))
Michal Ruprich e77f78c
+				(nfrontp > p+1 && (((*(p+1)&0xff) != EC) && ((*(p+1)&0xff) != EL))))
Michal Ruprich e77f78c
 
Michal Ruprich e77f78c
 #if	defined(ENCRYPT)
Michal Ruprich e77f78c
     thisitem = nclearto > netobuf ? nclearto : netobuf;
Michal Ruprich e77f78c
@@ -279,7 +286,7 @@ void netclear(void)
Michal Ruprich e77f78c
     thisitem = netobuf;
Michal Ruprich e77f78c
 #endif
Michal Ruprich e77f78c
 
Michal Ruprich e77f78c
-    while ((next = nextitem(thisitem)) <= nbackp) {
Michal Ruprich e77f78c
+    while ((next = nextitem(thisitem, nbackp)) != NULL && next <= nbackp) {
Michal Ruprich e77f78c
 	thisitem = next;
Michal Ruprich e77f78c
     }
Michal Ruprich e77f78c
 
Michal Ruprich e77f78c
@@ -291,20 +298,23 @@ void netclear(void)
Michal Ruprich e77f78c
     good = netobuf;	/* where the good bytes go */
Michal Ruprich e77f78c
 #endif
Michal Ruprich e77f78c
 
Michal Ruprich e77f78c
-    while (nfrontp > thisitem) {
Michal Ruprich e77f78c
+    while (thisitem != NULL && nfrontp > thisitem) {
Michal Ruprich e77f78c
 	if (wewant(thisitem)) {
Michal Ruprich e77f78c
 	    int length;
Michal Ruprich e77f78c
 
Michal Ruprich e77f78c
 	    next = thisitem;
Michal Ruprich e77f78c
 	    do {
Michal Ruprich e77f78c
-		next = nextitem(next);
Michal Ruprich e77f78c
-	    } while (wewant(next) && (nfrontp > next));
Michal Ruprich e77f78c
+		next = nextitem(next, nfrontp);
Michal Ruprich e77f78c
+	    } while (next != NULL && wewant(next) && (nfrontp > next));
Michal Ruprich e77f78c
+	    if (next == NULL) {
Michal Ruprich e77f78c
+		next = nfrontp;
Michal Ruprich e77f78c
+	    }
Michal Ruprich e77f78c
 	    length = next-thisitem;
Michal Ruprich e77f78c
 	    bcopy(thisitem, good, length);
Michal Ruprich e77f78c
 	    good += length;
Michal Ruprich e77f78c
 	    thisitem = next;
Michal Ruprich e77f78c
 	} else {
Michal Ruprich e77f78c
-	    thisitem = nextitem(thisitem);
Michal Ruprich e77f78c
+	    thisitem = nextitem(thisitem, nfrontp);
Michal Ruprich e77f78c
 	}
Michal Ruprich e77f78c
     }