PR#5: do not remove package from atomic and run inventory.yml when has classic tag - rpms/standard-test-roles

rpms / standard-test-roles

#5 do not remove package from atomic and run inventory.yml when has classic tag

Merged 6 years ago by astepano. Opened 6 years ago by bgoncalv.

rpms/ bgoncalv/standard-test-roles fix-tests-atomic into master

do not remove package from atomic and run inventory.yml when has classic tag

Bruno Goncalves • 6 years ago

fa65733

tests/inventory.yml

file modified

		`@@ -1,4 +1,6 @@`
		`- hosts: localhost`
		`+ tags:`
		`+ - always`
		`tasks:`
		`- name: Get inventory with empty input`
		`command: merge-standard-inventory`
		`@@ -6,6 +8,7 @@`
		`# Reset vars to default values`
		`TEST_SUBJECTS:`
		`register: inventory`
		`+ delegate_to: localhost`
		`- name: Assert merge-standard-inventory produces correct JSON inventory (list)`
		`fail:`
		`when: inventory.stdout\|from_json\|json_query('subjects.hosts')\|type_debug != 'list'`

tests/shared-tasks/req-pkg.yml

file modified

		`@@ -1,3 +1,7 @@`
		`+ - include_role:`
		`+ name: str-common`
		`+ tasks_from: inspect.yml`
astepano commented 6 years ago This task sets some ansible fact. What facts do we need?
bgoncalv commented 6 years ago we need `is_atomic` as we should not try to remove package if it is atomic.
astepano commented 6 years ago Ok. Thank you for explanation.
		`+`
		`- set_fact:`
		`req_pkg: zsh`

		`@@ -5,3 +9,4 @@`
		`package:`
		`name: "{{req_pkg}}"`
		`state: absent`
		`+ when: not is_atomic`

no initial comment

astepano commented on line 4 of tests/inventory.yml 6 years ago

No need.
Please inspect tests/inventory.yml file. This file does not include any role.
This tag is redundant.
This tag will rise questions: why it stays there.