#4 Fix -Wreturn-type warning
Closed 4 years ago by ekulik. Opened 4 years ago by tstellar.
rpms/ tstellar/satyr Wreturn-type-fix  into  master

@@ -0,0 +1,28 @@ 

+ From 8e202b5cf0889be98f34171ed152a16bd959d693 Mon Sep 17 00:00:00 2001

+ From: Tom Stellard <tstellar@redhat.com>

+ Date: Wed, 25 Mar 2020 03:04:45 +0000

+ Subject: [PATCH] Fix -Wreturn-type warning

+ 

+ ruby_frame.at:216:3: error: void function 'check' should not return a value [-Wreturn-type]

+ 

+ clang treates these as errors by default, so this was breaking the build with clang.

+ ---

+  tests/ruby_frame.at | 2 +-

+  1 file changed, 1 insertion(+), 1 deletion(-)

+ 

+ diff --git a/tests/ruby_frame.at b/tests/ruby_frame.at

+ index 15d367d..f6ca905 100644

+ --- a/tests/ruby_frame.at

+ +++ b/tests/ruby_frame.at

+ @@ -214,7 +214,7 @@ check(char *input)

+  

+    json_object_put(root);

+  

+ -  return 0;

+ +  return;

+  }

+  

+  int

+ -- 

+ 2.25.1

+ 

file modified
+10 -1
@@ -15,11 +15,15 @@ 

  

  Name: satyr

  Version: 0.30

- Release: 2%{?dist}

+ Release: 3%{?dist}

  Summary: Tools to create anonymous, machine-friendly problem reports

  License: GPLv2+

  URL: https://github.com/abrt/satyr

  Source0: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

+ 

+ # https://github.com/abrt/satyr/pull/300

+ Patch0: 0001-Fix-Wreturn-type-warning.patch

+ 

  %if %{with python3}

  BuildRequires: python3-devel

  %endif # with python3
@@ -71,6 +75,8 @@ 

  %prep

  %setup -q

  

+ %patch0 -p1

+ 

  %build

  %configure \

  %if %{without python3}
@@ -123,6 +129,9 @@ 

  %endif

  

  %changelog

+ * Wed Mar 25 2020 Tom Stellard <tstellar@redhat.com> - 0.30-3

+ - Fix -Wreturn-type warning

+ 

  * Fri Feb 07 2020 Ernestas Kulik <ekulik@redhat.com> - 0.30-2

  - Bump for side tag rebuild

  

clang treates these as errors by default, so this was breaking the build with clang.

Pull-Request has been closed by ekulik

4 years ago