PR#1: Update to Turbolinks 5.1.1. - rpms/rubygem-turbolinks

rpms / rubygem-turbolinks

#1 Update to Turbolinks 5.1.1.

Merged 5 years ago by pvalena. Opened 5 years ago by pvalena.

rpms/ pvalena/rubygem-turbolinks rebase into master

Update to turbolinks 5.1.1.

Pavel Valena • 5 years ago

27fbb0e

.gitignore

file modified

+1 -8

		`@@ -1,8 +1,1 @@`
		`- /turbolinks-1.1.1.gem`
		`- /turbolinks-1.3.0.gem`
		`- /turbolinks-2.2.1.gem`
		`- /turbolinks-2.2.2.gem`
		`- /turbolinks-2.4.0.gem`
		`- /turbolinks-2.5.3.gem`
		`- /turbolinks-5.0.0.gem`
		`- /turbolinks-5.0.1.gem`
		`+ /turbolinks-*.gem`

rubygem-turbolinks.spec

file modified

+5 -4

		`@@ -2,10 +2,9 @@`
		`%global gem_name turbolinks`

		`Name: rubygem-%{gem_name}`
		`- Version: 5.0.1`
		`- Release: 5%{?dist}`
		`+ Version: 5.1.1`
		`+ Release: 1%{?dist}`
		`Summary: Turbolinks makes navigating your web application faster`
		`- Group: Development/Languages`
		`License: MIT`
		`URL: https://github.com/turbolinks/turbolinks`
		`Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem`
		`@@ -20,7 +19,6 @@`

		`%package doc`
		`Summary: Documentation for %{name}`
		`- Group: Documentation`
		`Requires: %{name} = %{version}-%{release}`
		`BuildArch: noarch`

		`@@ -53,6 +51,9 @@`
		`%doc %{gem_instdir}/README.md`

		`%changelog`
		`+ * Wed Jul 18 2018 Pavel Valena <pvalena@redhat.com> - 5.1.1-1`
		`+ - Update to turbolinks 5.1.1.`
		`+`
		`* Sat Jul 14 2018 Fedora Release Engineering <releng@fedoraproject.org> - 5.0.1-5`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (turbolinks-5.0.1.gem) = 9bd57afdbf8ae33bca38f2d6a29f4147bf8894d5603390d0a9b35802471cce9a219f69965b9bcef553038e73400152187d3728d1fba1b8c7a17e22617c2353ed`
		`+ SHA512 (turbolinks-5.1.1.gem) = 1507966102f0e5ebdbc101d76db88ee55c50349629b417055ad2dbc8e6c8f391707adae85fc18ab92ea299302d1b1639519e340070e03b200c9e3c676d8d493f`

pvalena commented 5 years ago

Also enhance .spec and .gitignore files.

Scratch-build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=27899625

Checks:

rpmlint: ok
dependent packages: ok

jaruga commented 5 years ago

I prefer the commits are squashed as 1 commit.
Other things look ok to me.

pvalena commented 5 years ago

Yes, I'll squash first two commits, but I'll keep the third, as it is a separate case, IMO.

I'm in a process of running the tests with blade (I managed to build and install it locally).

jaruga commented 5 years ago

Sure. That makes sense.

I'm in a process of running the tests with blade (I managed to build and install it locally).

That's cool!

rebased onto 6b010cb

5 years ago

vondruch commented 5 years ago

I'm in a process of running the tests with blade (I managed to build and install it locally).

I don't want to discourage you, but as far as I remember, the dependency chain of blade was pretty nasty. Although I guess we have a few more dependencies in Fedora than we used to have ...

pvalena commented 5 years ago

I've forgotten to type further response- more to follow, but briefly:

You're right, not quite easy to run the test suite (also needs more than blade to run, apparently). Runtime dependencies of blade are already in my copr (no tests run yet):
https://copr.fedorainfracloud.org/coprs/pvalena/rubygem-blade/packages/

jaruga commented 5 years ago

I don't want to discourage you, but as far as I remember, the dependency chain of blade was pretty nasty. Although I guess we have a few more dependencies in Fedora than we used to have ...