PR#4: tests: add bundler unit tests - rpms/rubygem-bundler

Branch master could not be found in the target repo

rpms / rubygem-bundler

#4 tests: add bundler unit tests

Opened 6 years ago by mvadkert. Modified 6 years ago

rpms/ mvadkert/rubygem-bundler master into master

No commits found

mvadkert commented 6 years ago

This patch adds test which executes bundler unit tests
from the source rpm.

For more inforamtion how to run the tests see:

https://fedoraproject.org/wiki/CI/Quick_Start_Guide

Signed-off-by: Miroslav Vadkerti mvadkert@redhat.com

mvadkert commented 6 years ago

Note that currently the tests fail with:

Finished in 13 minutes 29 seconds (files took 0.70191 seconds to load)
2079 examples, 6 failures, 8 pending

This will need investigation from the package maintainers.

The logs which you should see when you run the tests are here:

https://paste.fedoraproject.org/paste/P-dMO-5WZsAp5HDj9IOnmg

mvadkert commented 6 years ago

Note that there are some tests, that fail on gcc not found, but the machine has gcc installed:

Example:

[root@efa5491fa605 bundler-unit-tests]# which gcc
/usr/bin/gcc

But the test log shows:

$ /usr/bin/ruby -I/tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/lib:/tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/spec -rsupport/hax /tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/exe/bundle install --path vendor/bundle --no-color
Fetching /tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/tmp/libs/very_simple_git_binary-1.0
Fetching source index from file:/tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/tmp/gems/remote1/
Resolving dependencies...
Using very_simple_git_binary 1.0 from /tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/tmp/libs/very_simple_git_binary-1.0 (at 49a0b5c@49a0b5c)
Using bundler 1.13.7
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    current directory: /tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/tmp/bundled_app/vendor/bundle/ruby/2.4.0/bundler/gems/very_simple_git_binary-1.0-49a0b5cfa293/ext
/usr/bin/ruby -r ./siteconf20180607-9036-bwe68i.rb extconf.rb
creating Makefile

current directory: /tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/tmp/bundled_app/vendor/bundle/ruby/2.4.0/bundler/gems/very_simple_git_binary-1.0-49a0b5cfa293/ext
make "DESTDIR=" clean
rm -f
rm -f very_simple_binary_c.so  *.o  *.bak mkmf.log .*.time

current directory: /tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/tmp/bundled_app/vendor/bundle/ruby/2.4.0/bundler/gems/very_simple_git_binary-1.0-49a0b5cfa293/ext
make "DESTDIR="
gcc -I. -I/usr/include -I/usr/include/ruby/backward -I/usr/include -I.   -fPIC -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -mtune=generic -fPIC -m64 -o very_simple_binary.o -c very_simple_binary.c
make: gcc: Command not found
make: *** [Makefile:243: very_simple_binary.o] Error 127

make failed, exit code 2

Gem files will remain installed in /tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/tmp/bundled_app/vendor/bundle/ruby/2.4.0/bundler/gems/very_simple_git_binary-1.0-49a0b5cfa293 for inspection.
Results logged to /tmp/tmp.wENAp3wVg3/BUILD/rubygem-bundler-1.13.7/usr/share/gems/gems/bundler-1.13.7/tmp/bundled_app/vendor/bundle/ruby/2.4.0/bundler/gems/extensions/x86_64-linux/2.4.0/very_simple_git_binary-1.0-49a0b5cfa293/gem_make.out

An error occurred while installing very_simple_git_binary (1.0), and Bundler cannot continue.
# $? => 5
  doesn't remove extensions artifacts from bundled git gems after clean (FAILED - 2)

mvadkert commented 6 years ago

@vondruch maybe there is a problem with $PATH during running of tests. I have no other idea :(