#163 De-hardcode py_SOVERSION in the files section
Merged 4 years ago by churchyard. Opened 4 years ago by torsava.
rpms/ torsava/python3 master  into  master

file modified
+1 -1
@@ -1556,7 +1556,7 @@ 

  %{_bindir}/python%{LDVERSION_debug}-config

  %{_bindir}/python%{LDVERSION_debug}-*-config

  %{_libdir}/libpython%{LDVERSION_debug}.so

- %{_libdir}/libpython%{LDVERSION_debug}.so.1.0

+ %{_libdir}/libpython%{LDVERSION_debug}.so.%{py_SOVERSION}

  %{_libdir}/pkgconfig/python-%{LDVERSION_debug}.pc

  %{_libdir}/pkgconfig/python-%{LDVERSION_debug}-embed.pc

  

no initial comment

Nice. Where did this bite you?

Metadata Update from @churchyard:
- Pull-request tagged with: merge - rebase - CI

4 years ago

I never understood the SOVERSION thing. Who decides to increase SOVERSION?

Build failed.

i'm not sure why it failed, the job worked recently for python-gear ( https://fedora.softwarefactory-project.io/zuul/builds?job_name=rpm-scratch-build ). I've requested a node hold, i'll try to debug more using ssh access.

Build failed.

Ok, actually the weird error seems to be just mock failing to cleanup, the real issue seems to be error: Bad source: /builddir/build/SOURCES/Python-3.8.1.tar.xz: No such file or directory

And it seems to be caused by
error: line 674: Unclosed %if which prevent spectool to download the sources

Or something else I don't know. The procedure to download the source doesn't seems to work with the python3.spec file.

@churchyard would you see why this task doesn't work: https://pagure.io/zuul-distro-jobs/blob/master/f/roles/mock-srpm-build/tasks/main.yaml#_6 . If so, we could open a PR on zuul-distro-jobs, and test it here using Depends-On

That might be https://pagure.io/rpmdevtools/issue/38

But in order to test the Fedora environment, the job should not try to get sources from urls, it should use fedpkg sources or fedpkg srpm. That's what happens in Fedora. The URL might even be missing in some cases.

Ok we'll merge this https://pagure.io/fedora-zuul-jobs-config/pull-request/20 to make use of fedpkg to build the srpm.

Build failed.

Our builds take usually up to 2 hours on arm, but if we can limit the architectures, it can be much faster.

Yes we can maybe start by limiting on x86_64 only. After all, on the CI we provide, AFAIK we won't be able to validate the build with functional tests (rpm-test job (tests/tests.yml)) on something else than x86_84.

I'll change the fedpkg-rpm-build role to handle a list of architectures in case of scratch build. And set x86_64 as the default arch in that list.

Build failed.

It seems the build on koji for x86_64 failed on a test: https://fedora.softwarefactory-project.io/zuul/build/bc5d251efc9e4b00800ef7b613c0a58f/log/job-output.txt#220

FAIL: test_add_file_after_2107 (test.test_zipfile.StoredTestsWithSourceFile)

also note that the artifacts retrieval from koji in case of failing build is not working well. The fedpkg-build role (https://pagure.io/zuul-distro-jobs/blob/master/f/roles/fedpkg-build/tasks/main.yaml#_22) will need some improvements to make the koji build logs available in the zuul job result page.

That failure is known to us and it's a new problem in rawhide. Will get back to this once we fix it.

Build failed.

FAIL: test_add_file_after_2107 (test.test_zipfile.StoredTestsWithSourceFile)

FYI I reported an issue for this test today to Python upstream: https://bugs.python.org/issue39460 "test_zipfile: test_add_file_after_2107() fails on s390x Fedora Rawhide 3.x".

Metadata Update from @churchyard:
- Pull-request tagged with: blocked

4 years ago

Nice. Where did this bite you?

SCLs change that, because of course they do :)

SCLs change that, because of course they do :)

rebased onto 97e152a

4 years ago

Metadata Update from @churchyard:
- Pull-request untagged with: blocked

4 years ago

Build succeeded.

Pull-Request has been merged by churchyard

4 years ago