#12 Revert "Skip all SSL related tests", use OpenSSL 1.0 instead
Closed 3 years ago by churchyard. Opened 3 years ago by churchyard.
rpms/ churchyard/python3.5 openssl1.0  into  master

file modified
+6 -10
@@ -87,7 +87,7 @@ 

  #global prerel ...

  %global upstream_version %{general_version}%{?prerel}

  Version: %{general_version}%{?prerel:~%{prerel}}

- Release: 1%{?dist}

+ Release: 2%{?dist}

  License: Python

  

  # Whether to use RPM build wheels from the python-{pip,setuptools}-wheel package
@@ -125,7 +125,7 @@ 

  BuildRequires: ncurses-devel

  # workaround http://bugs.python.org/issue19804 (test_uuid requires ifconfig)

  BuildRequires: net-tools

- BuildRequires: openssl-devel

+ BuildRequires: compat-openssl10-devel

  BuildRequires: pkgconfig

  BuildRequires: readline-devel

  BuildRequires: sqlite-devel
@@ -1013,8 +1013,6 @@ 

    #   @unittest._expectedFailureInRpmBuild

    # test_faulthandler.test_register_chain currently fails on ppc64le and

    #   aarch64, see upstream bug http://bugs.python.org/issue21131

-   # all SSL related tests are skipped

-   #   see https://mail.python.org/archives/list/python-dev@python.org/message/3Z6X4LPSNRHHW4QPLLAVSNYY6CS6DDNR/

    WITHIN_PYTHON_RPM_BUILD= \

    LD_LIBRARY_PATH=$ConfDir $ConfDir/python -m test.regrtest \

      --verbose --findleaks \
@@ -1028,12 +1026,6 @@ 

      %ifarch %{power64} s390 s390x armv7hl aarch64 %{mips}

      -x test_gdb \

      %endif

-     -x test_asyncio \

-     -x test_ftplib \

-     -x test_httplib \

-     -x test_poplib \

-     -x test_ssl\

-     -x test_urllib2_localnet \

  

    echo FINISHED: CHECKING OF PYTHON FOR CONFIGURATION: $ConfName

  
@@ -1117,6 +1109,10 @@ 

  # ======================================================

  

  %changelog

+ * Wed Sep 16 2020 Miro Hrončok <mhroncok@redhat.com> - 3.5.10-2

+ - Use OpenSSL 1.0

+ - Fixes: rhbz#1859556

+ 

  * Mon Sep 07 2020 Tomas Hrnciar <thrnciar@redhat.com> - 3.5.10-1

  - Update to 3.5.10

  

Build succeeded.

Tests passed, the diff looks good to me.

Now what is a better approach here?

  • broken OpenSSL integration?
  • upstream unsupported OpenSSL version?

For an upstream unsupported interpreter? The latter :)

I tend to agree. We can always switch back once OpenSSL 1.0 is orphaned/retired/broken more than Python 3.5 with OpenSSL 1.1.

LGTM.

Working ssl module sounds better to me than skipping many tests using TLS security.

compat-openssl10 has just been retired.

Pull-Request has been closed by churchyard

3 years ago