#11 Update to 0.33.6 (#1708194), Don't test Python 2 on Fedora 32+
Merged 4 years ago by churchyard. Opened 4 years ago by churchyard.
rpms/ churchyard/python-wheel 0.33.6  into  master

file modified
+1
@@ -7,3 +7,4 @@ 

  /wheel-0.31.1.tar.gz

  /wheel-0.32.0.tar.gz

  /wheel-0.33.1.tar.gz

+ /wheel-0.33.6.tar.gz

file modified
+9 -5
@@ -9,8 +9,8 @@ 

  %global python_wheeldir %{_datadir}/python-wheels

  

  Name:           python-%{pypi_name}

- Version:        0.33.1

- Release:        5%{?dist}

+ Version:        0.33.6

+ Release:        1%{?dist}

  Epoch:          1

  Summary:        Built-package format for Python

  
@@ -19,7 +19,7 @@ 

  Source0:        %{url}/archive/%{version}/%{pypi_name}-%{version}.tar.gz

  BuildArch:      noarch

  

- %if ! %{with bootstrap}

+ %if %{without bootstrap}

  # several tests compile extensions

  # those tests are skipped if gcc is not found

  BuildRequires:  gcc
@@ -41,7 +41,7 @@ 

  Summary:        %{summary}

  BuildRequires:  python2-devel

  BuildRequires:  python2-setuptools

- %if ! %{with bootstrap}

+ %if %{without bootstrap} && 0%{?fedora} < 32

  BuildRequires:  python2-pytest

  %endif

  %{?python_provide:%python_provide python2-%{pypi_name}}
@@ -116,7 +116,7 @@ 

  

  %check

  rm setup.cfg

- %if %{with python2}

+ %if %{with python2} && 0%{?fedora} < 32

  PYTHONPATH=%{buildroot}%{python2_sitelib} py.test-2 -v --ignore build

  %endif

  PYTHONPATH=%{buildroot}%{python3_sitelib} py.test-3 -v --ignore build
@@ -148,6 +148,10 @@ 

  %endif

  

  %changelog

+ * Tue Aug 27 2019 Miro Hrončok <mhroncok@redhat.com> - 1:0.33.6-1

+ - Update to 0.33.6 (#1708194)

+ - Don't add the m ABI flag to wheel names on Python 3.8

+ 

  * Thu Aug 15 2019 Miro Hrončok <mhroncok@redhat.com> - 1:0.33.1-5

  - Rebuilt for Python 3.8

  

file modified
+1 -1
@@ -1,1 +1,1 @@ 

- SHA512 (wheel-0.33.1.tar.gz) = d275715ebd4fa81ac02a3b0d33144348c47a4cb84b58ad0c0e0f120900c6696c81f750a5c8835519189dec08aa58f78394f26c5c379ab03ffdb7eaa73097f928

+ SHA512 (wheel-0.33.6.tar.gz) = 04edf619ee6fd06f1e4c8bc513c6e21ba91615eba42bca5473e60573e274133b1019774b8e3a960e05f5a69bb256508d0a8a31fd9ab91a28f1b87d1095b17b5e

no initial comment

Most of the file uses %if %{without bootstrap}, so I would replace this and the other occurrence of %if ! %{with bootstrap} with it, for consistency.

Is this part of the new version of wheel? I don't see anything relevant about it in the commit.

I would also mention the turned off Python 2 tests on >= F32 in the changelog.

I would also mention the turned off Python 2 tests on >= F32 in the changelog.

How is that relevant to the user?

That's a cherrypicked (IMHO most important) line from the upstream changelog

1 new commit added

  • `Replace all%if ! %{with bootstrap}with%if %{without bootstrap}```
4 years ago

I've pushed a commit with ! with -> without

I would also mention the turned off Python 2 tests on >= F32 in the changelog.

How is that relevant to the user?

Knowing the package won't be tested and thus will be potentially less stable and vulnerable. Not a hard requirement, so feel free to ignore.

That's a cherrypicked (IMHO most important) line from the upstream changelog

Ok.

LGTM!

Knowing the package won't be tested and thus will be potentially less stable and vulnerable.

If testing was omnipresent in Fedora packages, i would agree here.

Merging, nobody reads the changelog anyway :D

Pull-Request has been merged by churchyard

4 years ago