#28 Run Python 3.4 tests optionally
Merged 3 years ago by churchyard. Opened 3 years ago by churchyard.
rpms/ churchyard/python-virtualenv no34  into  master

file modified
+6 -7
@@ -11,15 +11,15 @@ 

      - smoke27:

          dir: python/smoke

          run: VERSION=2.7 METHOD=virtualenv ./venv.sh

-     - smoke34:

+     - smoke34_optional:

          dir: python/smoke

-         run: VERSION=3.4 METHOD=virtualenv ./venv.sh

-     - smoke34nd:

+         run: VERSION=3.4 METHOD=virtualenv INSTALL_OR_SKIP=true ./venv.sh

+     - smoke34nd_optional:

          dir: python/smoke

-         run: VERSION=3.4 METHOD=virtualenv-no-download ./venv.sh

-     - smoke34sp:

+         run: VERSION=3.4 METHOD=virtualenv-no-download INSTALL_OR_SKIP=true ./venv.sh

+     - smoke34sp_optional:

          dir: python/smoke

-         run: VERSION=3.4 METHOD=virtualenv-seeder-pip ./venv.sh

+         run: VERSION=3.4 METHOD=virtualenv-seeder-pip INSTALL_OR_SKIP=true ./venv.sh

      - smoke35:

          dir: python/smoke

          run: VERSION=3.5 METHOD=virtualenv ./venv.sh
@@ -42,7 +42,6 @@ 

      - gcc

      - virtualenv

      - python27

-     - python34

      - python35

      - python36

      - python37

Build succeeded.

The new configuration looks good to me and both CI systems seem to be happy with it. Interesting is that the tests share the environment so only the first optional test actually installs python3.4.

:thumbsup:

Interesting is that the tests share the environment so only the first optional test actually installs python3.4.

Yes. That is the expected case. However the INSTALL_OR_SKIP option needs to be used in all of them for the case when python34 is gone.

Do we want to wait for that to happen and retest?

Pull-Request has been merged by churchyard

3 years ago