Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

Build failed.

• rpm-scratch-build : SUCCESS in 8m 28s
• rpm-linter : FAILURE in 3m 23s
• rpm-rpminspect : POST_FAILURE in 4m 18s (non-voting)
• check-for-tests : SUCCESS in 6s
• rpm-install-test : SKIPPED
• rpm-test : SUCCESS in 12m 27s

There is an rpmlint error.

E: zero-length /usr/lib/python3.9/site-packages/setuptools-49.6.0.dist-info/REQUESTED

I'll try to change the general rpmlint configuration in Fedora to filter this out.

Zuul appears to use Fedora 32 to run rpmlint (right @fbo?).

https://bodhi.fedoraproject.org/updates/FEDORA-2020-e17f5f1103 is the Fedora 32 backport of the configuration change.

About the newly added patch. There is this is %prep:

# We don't do linting or coverage here
sed -i pytest.ini -e 's/ --flake8//' \
                  -e 's/ --cov//'

I don't want to discuss whether a patch or sed call is better, but certainly we should not need both. Has it stopped working?

Oops, I missed that. It does work without the patch; let me get rid of it.

Build failed.

• rpm-scratch-build : SUCCESS in 8m 54s
• rpm-linter : FAILURE in 3m 27s
• rpm-rpminspect : POST_FAILURE in 4m 16s (non-voting)
• check-for-tests : SUCCESS in 16s
• rpm-install-test : SKIPPED
• rpm-test : SUCCESS in 11m 20s

Interesting failure in https://copr.fedorainfracloud.org/coprs/churchyard/setuptools-49.6.0/package/numpy/

=================================== FAILURES ===================================
_________________________ TestF77Mismatch.test_lapack __________________________

self = <numpy.linalg.tests.test_build.TestF77Mismatch object at 0x7f23accae8e0>

    @pytest.mark.skipif(not(sys.platform[:5] == 'linux'),
                        reason="no fortran compiler on non-Linux platform")
    def test_lapack(self):
        f = FindDependenciesLdd()
>       deps = f.grep_dependencies(lapack_lite.__file__,
                                   [b'libg2c', b'libgfortran'])

f          = <numpy.linalg.tests.test_build.FindDependenciesLdd object at 0x7f23a4fb6be0>
self       = <numpy.linalg.tests.test_build.TestF77Mismatch object at 0x7f23accae8e0>

numpy/linalg/tests/test_build.py:48: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
numpy/linalg/tests/test_build.py:30: in grep_dependencies
    stdout = self.get_dependencies(lfile)
        deps       = [b'libg2c', b'libgfortran']
        lfile      = '/builddir/build/BUILD/numpy-1.19.1/build/testenv/lib64/python3.9/site-packages/numpy/linalg/lapack_lite.cpython-39-x86_64-linux-gnu.so'
        self       = <numpy.linalg.tests.test_build.FindDependenciesLdd object at 0x7f23a4fb6be0>
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <numpy.linalg.tests.test_build.FindDependenciesLdd object at 0x7f23a4fb6be0>
lfile = '/builddir/build/BUILD/numpy-1.19.1/build/testenv/lib64/python3.9/site-packages/numpy/linalg/lapack_lite.cpython-39-x86_64-linux-gnu.so'

    def get_dependencies(self, lfile):
        p = Popen(self.cmd + [lfile], stdout=PIPE, stderr=PIPE)
        stdout, stderr = p.communicate()
        if not (p.returncode == 0):
>           raise RuntimeError("failed dependencies check for %s" % lfile)
E           RuntimeError: failed dependencies check for /builddir/build/BUILD/numpy-1.19.1/build/testenv/lib64/python3.9/site-packages/numpy/linalg/lapack_lite.cpython-39-x86_64-linux-gnu.so

lfile      = '/builddir/build/BUILD/numpy-1.19.1/build/testenv/lib64/python3.9/site-packages/numpy/linalg/lapack_lite.cpython-39-x86_64-linux-gnu.so'
p          = <Popen: returncode: 1 args: ['ldd', '/builddir/build/BUILD/numpy-1.19.1/buil...>
self       = <numpy.linalg.tests.test_build.FindDependenciesLdd object at 0x7f23a4fb6be0>
stderr     = b"ldd: error: you do not have read permission for `/builddir/build/BUILD/numpy-1.19.1/build/testenv/lib64/python3.9/site-packages/numpy/linalg/lapack_lite.cpython-39-x86_64-linux-gnu.so'\n"
stdout     = b''

numpy/linalg/tests/test_build.py:25: RuntimeError

Due to https://fedoraproject.org/wiki/Changes/Making_sudo_pip_safe we patch distutils (see patch 251 in python3.9 package or the commit in https://github.com/fedora-python/cpython/commits/fedora-3.9).

Setuptools bundles the same code here. I wonder whether we need to repeat the patch here as well. Will do some testing.

Yes, running:

$ export SETUPTOOLS_USE_DISTUTILS=local
$ sudo python3 setup.py install

Makes the project go into /usr/lib/python3.9/site-packages. We need to apply the patch here as well :(

Also technically, if people will update setuptools in their local and then use it to sudo install stuff, they'll get this as well. Not much we can do about this code-wise I am afraid.

I asked upstream about this in https://github.com/pypa/setuptools/issues/2232

The numpy failure seem to no longer happen, running a third build to verify.

The local distutils is only used on demand, so I think we can ship this (I'll verify).