PR#1: Add a build-time dependency on python2-devel and modernize spec file - rpms/python-repoze-what

rpms / python-repoze-what

#1 Add a build-time dependency on python2-devel and modernize spec file

Merged 6 years ago by kevin. Opened 6 years ago by ishcherb.

rpms/ ishcherb/python-repoze-what master into master

Add a build-time dependency on python2-devel and modernize spec file

ishcherb • 6 years ago

d64e7bb

python-repoze-what.spec

file modified

+8 -7

		`@@ -1,8 +1,6 @@`
		`- %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}`
		`-`
		`Name: python-repoze-what`
		`Version: 1.0.9`
		`- Release: 15%{?dist}`
		`+ Release: 16%{?dist}`
		`Summary: Authorization for WSGI applications`

		`Group: Development/Languages`
		`@@ -13,7 +11,7 @@`
		`Patch1: %{name}-release.patch`
		`BuildArch: noarch`

		`- BuildRequires: python-setuptools`
		`+ BuildRequires: python2-devel`

		`# For building documentation`
		`BuildRequires: python-sphinx`
		`@@ -64,12 +62,12 @@`
		`sed -i "/'repoze.who.*$/d" setup.py`

		`%build`
		`- %{__python} setup.py build`
		`+ %py2_build`
		`make -C docs html`


		`%install`
		`- %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT`
		`+ %py2_install`

		`%check`
		`# Causing package to be FTBFS since F-19!`
		`@@ -77,13 +75,16 @@`

		`%files`
		`%doc README.txt`
		`- %{python_sitelib}/`
		`+ %{python2_sitelib}/`

		`%files docs`
		`%doc docs/`


		`%changelog`
		`+ * Thu Aug 10 2017 Iryna Shcherbina <ishcherb@redhat.com> - 1.0.9-16`
		`+ - Add a build-time dependency on python2-devel and modernize spec file`
		`+`
		`* Thu Jul 27 2017 Fedora Release Engineering <releng@fedoraproject.org> - 1.0.9-15`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild`

ishcherb commented 6 years ago

A build-time dependency on python2-devel is missing.

This is the reason why the dependency on Python itself is not generated for python-repoze-what-0:1.0.9-15.fc27:

$ dnf repoquery --disablerepo=* --enablerepo=rawhide --requires python-repoze-what | grep python
python-paste
python-repoze-who
python-repoze-who-testutil

According to Fedora Packaging Guidelines for Python [0], packages building for Python 2 need BuildRequires: python2-devel.

[0] https://fedoraproject.org/wiki/Packaging:Python#Dependencies