PR#6: spec: replace hardcoded python3 - rpms/python-pygments

rpms / python-pygments

#6 spec: replace hardcoded python3

Merged 3 years ago by churchyard. Opened 3 years ago by fepitre.

rpms/ fepitre/python-pygments python3 into master

spec: replace hardcoded python3

Frédéric Pierret (fepitre) • 3 years ago

8ff7f90

python-pygments.spec

file modified

+8 -8

		`@@ -30,19 +30,19 @@`

		`%description %_description`

		`- %package -n python3-pygments`
		`- BuildRequires: python3-devel`
		`- BuildRequires: python3-setuptools`
		`+ %package -n python%{python3_pkgversion}-pygments`
		`+ BuildRequires: python%{python3_pkgversion}-devel`
		`+ BuildRequires: python%{python3_pkgversion}-setuptools`
		`%if %{with tests}`
		`- BuildRequires: python3-pytest`
		`+ BuildRequires: python%{python3_pkgversion}-pytest`
		`%endif`
		`%if %{with docs}`
		`- BuildRequires: python3-sphinx`
		`+ BuildRequires: python%{python3_pkgversion}-sphinx`
		`%endif`
		`Summary: Syntax highlighting engine written in Python`
		`- %{?python_provide:%python_provide python3-pygments}`
		`+ %{?python_provide:%python_provide python%{python3_pkgversion}-pygments}`

		`- %description -n python3-pygments %_description`
		`+ %description -n python%{python3_pkgversion}-pygments %_description`

		`%prep`
		`%autosetup -p1 -n Pygments-%{version}`
		`@@ -69,7 +69,7 @@`
		`%endif`


		`- %files -n python3-pygments`
		`+ %files -n python%{python3_pkgversion}-pygments`
		`%doc AUTHORS CHANGES doc/reST`
		`%license LICENSE`
		`%{python3_sitelib}/pygments/`

fepitre commented 3 years ago

Signed-off-by: Frédéric Pierret (fepitre) frederic.pierret@qubes-os.org

rebased onto 8ff7f90

3 years ago

churchyard commented 3 years ago

What is the reason?

fepitre commented 3 years ago

That's for allowing to build under CentOS 8 with Python38 modules.

churchyard commented 3 years ago

I don't understand. Doesn't CentOS 8 only rebuild RHEL 8 packages?

fepitre commented 3 years ago

I'm not part of CentOS project. I'm trying to create a COPR repository for CentOS 8 which extends the very minimal available python 38 packages. Generally using the macro python3_pkgversion helps to manage multiple python versions available. I'm currently PR all the tested packages under Centos 8.

churchyard commented 3 years ago

Understood. I can merge this, but note that I plan to eventually drop legacy stuff (e.g. %python_provide) from the master branch. Not sure how much that affects EL8 compatibility.