PR#10: Fedora CI: Add %pyproject macros integration tests - rpms/python-packaging

rpms / python-packaging

#10 Fedora CI: Add %pyproject macros integration tests

Merged 4 years ago by lbalhar. Opened 4 years ago by churchyard.

rpms/ churchyard/python-packaging fedora_ci into master

Enable gating

Miro Hrončok • 4 years ago

5e0e21e

Fedora CI: Add %pyproject macros integration tests

Miro Hrončok • 4 years ago

3a2a642

gating.yaml

file added

		`@@ -0,0 +1,7 @@`
		`+ --- !Policy`
		`+ product_versions:`
		`+ - fedora-*`
		`+ decision_context: bodhi_update_push_stable`
		`+ subject_type: koji_build`
		`+ rules:`
		`+ - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}`

tests/tests.yml

file added

+26

		`@@ -0,0 +1,26 @@`
		`+ ---`
		`+ - hosts: localhost`
		`+ roles:`
		`+ - role: standard-test-basic`
		`+ tags:`
		`+ - classic`
		`+ repositories:`
		`+ - repo: "https://src.fedoraproject.org/rpms/pyproject-rpm-macros.git"`
		`+ dest: "pyproject-rpm-macros"`
		`+ tests:`
		`+ - pyproject_pytest:`
		`+ dir: pyproject-rpm-macros/tests`
		`+ run: ./mocktest.sh python-pytest`
		`+ - pyproject_entrypoints:`
		`+ dir: pyproject-rpm-macros/tests`
		`+ run: ./mocktest.sh python-entrypoints`
		`+ - pyproject_pluggy:`
		`+ dir: pyproject-rpm-macros/tests`
		`+ run: ./mocktest.sh python-pluggy`
		`+ - pyproject_clikit:`
		`+ dir: pyproject-rpm-macros/tests`
		`+ run: ./mocktest.sh python-clikit`
		`+ required_packages:`
		`+ - mock`
		`+ - rpmdevtools`
		`+ - rpm-build`

churchyard commented 4 years ago

(Don't merge before we verify the results in the CI.)

churchyard commented 4 years ago

Looks good:

================================================================================
 Package                  Arch    Version          Repository              Size
================================================================================
Installing:
 pyproject-rpm-macros     noarch  0-13.fc33        local                   16 k
Installing dependencies:
 gdbm-libs                x86_64  1:1.18.1-3.fc32  fedora                  54 k
 python-pip-wheel         noarch  19.3.1-2.fc32    fedora                 1.2 M
 python-rpm-macros        noarch  3-54.fc32        fedora                  13 k
 python-setuptools-wheel  noarch  45.2.0-1.fc33    fedora                 294 k
 python3                  x86_64  3.8.2-2.fc33     fedora                  30 k
 python3-devel            x86_64  3.8.2-2.fc33     fedora                 202 k
 python3-libs             x86_64  3.8.2-2.fc33     fedora                 7.4 M
 python3-packaging        noarch  20.3-1.fc33      test-python-packaging   66 k
 python3-pip              noarch  19.3.1-2.fc32    fedora                 1.7 M
 python3-pyparsing        noarch  2.4.6-2.fc32     fedora                 149 k
 python3-pytoml           noarch  0.1.18-8.fc32    fedora                  24 k
 python3-rpm-generators   noarch  10-4.fc32        fedora                  24 k
 python3-rpm-macros       noarch  3-54.fc32        fedora                  11 k
 python3-setuptools       noarch  45.2.0-1.fc33    fedora                 596 k
 python3-six              noarch  1.14.0-2.fc32    fedora                  36 k
 sqlite-libs              x86_64  3.31.1-1.fc32    fedora                 611 k

lbalhar commented 4 years ago

I don't understand it but I trust you. Should I merge it?

churchyard commented 4 years ago

In short:

there are integration tests living in https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/master/f/tests
upon a new PR or build, this downloads them and runs them
packaging is needed by pyproject-rpm-macros, hence it can break it potentailly

Should I merge it?

Sure. Also, there are 2 possible ways going forward to ensure the test run:

pull request mode only - this ensures the CI tests run before a change is merged/pushed
gating - this prevents an update going to stable (even on rawhide) should it break %pyproject macros

What do you prefer?

churchyard commented 4 years ago

@lbalhar What do you prefer?

lbalhar commented 4 years ago

Does gating include pull requests check? If so I'd prefer to have both PR check and gating check.

churchyard commented 4 years ago

Not sure I understand your question correctly, but I assume you ask if the checks are still run on new PRs when the gating is enabled. Yes.

Let me amend this PR to enable gating then.

1 new commit added