From b6ee4f2ad7bd7982e4d6291934496f5871cbf5ba Mon Sep 17 00:00:00 2001
From: yatin <ykarel@redhat.com>
Date: Oct 11 2017 14:47:59 +0000
Subject: Incorporate some nits in spec from rdo-review


---

diff --git a/python-os-service-types.spec b/python-os-service-types.spec
index 0449843..ef560d9 100644
--- a/python-os-service-types.spec
+++ b/python-os-service-types.spec
@@ -16,7 +16,7 @@ and local caching of the fetched data.
 
 Name:           python-%{pypi_name}
 Version:        1.1.0
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Python library for consuming OpenStack sevice-types-authority data
 
 License:        ASL 2.0
@@ -25,7 +25,7 @@ Source0:        https://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{versi
 BuildArch:      noarch
 
 BuildRequires:  git
- 
+
 %description
 %{common_desc}
 
@@ -35,13 +35,13 @@ Summary:        %{summary}
 
 BuildRequires:  python2-devel
 BuildRequires:  python2-pbr
-BuildRequires:  python2-subunit
+BuildRequires:  python-subunit
 BuildRequires:  python2-oslotest
 BuildRequires:  python-testscenarios
 BuildRequires:  python-requests-mock
 BuildRequires:  python2-keystoneauth1
 BuildRequires:  python2-setuptools
- 
+
 Requires:       python2-pbr >= 2.0.0
 %description -n python2-%{pypi_name}
 %{common_desc}
@@ -59,7 +59,7 @@ BuildRequires:  python3-testscenarios
 BuildRequires:  python3-requests-mock
 BuildRequires:  python3-keystoneauth1
 BuildRequires:  python3-setuptools
- 
+
 Requires:       python3-pbr >= 2.0.0
 %description -n python3-%{pypi_name}
 %{common_desc}
@@ -83,17 +83,17 @@ Documentation for %{pypi_name}
 rm -rf %{pypi_name}.egg-info
 
 %build
-%if 0%{with_python3}
+%if 0%{?with_python3}
 %py3_build
 %endif
 %py2_build
-# generate html docs 
+# generate html docs
 %{__python2} setup.py build_sphinx -b html
 # remove the sphinx-build leftovers
 rm -rf doc/build/html/.{doctrees,buildinfo}
 
 %install
-%if 0%{with_python3}
+%if 0%{?with_python3}
 %py3_install
 %endif
 
@@ -113,7 +113,7 @@ rm -rf doc/build/html/.{doctrees,buildinfo}
 %{python2_sitelib}/%{module_name}
 %{python2_sitelib}/%{module_name}-%{version}-py?.?.egg-info
 
-%if 0%{with_python3}
+%if 0%{?with_python3}
 %files -n python3-%{pypi_name}
 %license LICENSE
 %doc README.rst doc/source/readme.rst
@@ -123,8 +123,10 @@ rm -rf doc/build/html/.{doctrees,buildinfo}
 
 %files -n python-%{pypi_name}-doc
 %license LICENSE
-%doc doc/build/html 
+%doc doc/build/html
 
 %changelog
+* Wed Oct 11 2017 ykarel <ykarel@redhat.com> - 1.1.0-2
+- Incorporate some nits in spec from rdo-review
 * Tue Oct 10 2017 ykarel <ykarel@redhat.com> - 1.1.0-1
 - Initial package.