PR#7: Update to 8.5.0 (#1873653) & switch to pyproject macros - rpms/python-more-itertools

rpms / python-more-itertools

#7 Update to 8.5.0 (#1873653) & switch to pyproject macros

Merged 3 years ago by lbalhar. Opened 3 years ago by lbalhar.

rpms/ lbalhar/python-more-itertools master into master

Update to 8.5.0 (#1873653) & switch to pyproject macros

Lumir Balhar • 3 years ago

caa76f8

python-more-itertools.spec

file modified

+17 -10

		`@@ -1,6 +1,8 @@`
		`+ %bcond_without tests`
		`%global srcname more-itertools`
		`+`
		`Name: python-%{srcname}`
		`- Version: 8.4.0`
		`+ Version: 8.5.0`
		`Release: 1%{?dist}`
		`Summary: More routines for operating on Python iterables, beyond itertools`
		`License: MIT`
		`@@ -9,8 +11,7 @@`
		`BuildArch: noarch`

		`BuildRequires: python3-devel`
		`- BuildRequires: python3-setuptools`
		`- BuildRequires: python3-six`
		`+ BuildRequires: pyproject-rpm-macros`

		`%global _description %{expand:`
		`Python's itertools library is a gem - you can compose elegant solutions for`
		`@@ -29,23 +30,29 @@`
		`%prep`
		`%autosetup -n %{srcname}-%{version}`

		`+ %generate_buildrequires`
		`+ %pyproject_buildrequires %{?with_tests:-r -t}`
		`+`
		`%build`
		`- %py3_build`
		`+ %pyproject_wheel`

		`%install`
		`- %py3_install`
		`+ %pyproject_install`
		`+ %pyproject_save_files more_itertools`

		`+ %if %{with tests}`
		`%check`
		`- %{python3} setup.py test`
		`+ %tox`
		`+ %endif`

		`- %files -n python3-%{srcname}`
		`+ %files -n python3-%{srcname} -f %pyproject_files`
		`%license LICENSE`
		`%doc README.rst PKG-INFO`
		`- %{python3_sitelib}/more_itertools/`
		`- %exclude %{python3_sitelib}/more_itertools/tests`
		`- %{python3_sitelib}/more_itertools-%{version}-py%{python3_version}.egg-info/`

		`%changelog`
		`+ * Wed Sep 09 2020 Lumír Balhar <lbalhar@redhat.com> - 8.5.0-1`
		`+ - Update to 8.5.0 (#1873653)`
		`+`
		`* Wed Jul 29 2020 Miro Hrončok <mhroncok@redhat.com> - 8.4.0-1`
		`- Update to 8.4.0`
		`- Fixes rhbz#1778332`

sources

file modified

+1 -1

		`@@ -1,1 +1,1 @@`
		`- SHA512 (more-itertools-8.4.0.tar.gz) = 70bf72594cb92b165f1bdc5050bcd3d7d37eeee65db6c631b636222005f8d7707d0c6ab09a229e9f1a23fdcf2be948e96d0882f9fa033f29b7a472ec8441a4d0`
		`+ SHA512 (more-itertools-8.5.0.tar.gz) = f11a4443d4d5e79fe241fc6e170ae51b08cfb1f1093dddad036e1ba043c30d03c53ab9fccbfb4de97279862c6cfe44759ae88ce6027d871515b032e7d9e435e7`

lbalhar commented 3 years ago

Dependant packages build fine: https://copr.fedorainfracloud.org/coprs/lbalhar/python-more-itertools-8.5.0/builds/

churchyard commented 3 years ago

It is very likely that this package will need to be built before tox is available. Could you please use a tests bcond, similarly to https://src.fedoraproject.org/rpms/python-toml/pull-request/4 ?

rebased onto 034027b

3 years ago

lbalhar commented 3 years ago

Done.

churchyard commented on line 26 of python-more-itertools.spec 3 years ago

Are the runtime requires (-r) needed without tests?

lbalhar commented 3 years ago

They are not, fixed.

rebased onto caa76f8

3 years ago

churchyard commented 3 years ago

The PR is good to be merged, thanks.

A curiosity-driven question thou: Do you add the -r flag because you like to be more explicit, or because the documentation is not good wrt this flag and the -t flag?

lbalhar commented 3 years ago

The documentation is good I was doing a lot of packages at the same time and my knowledge about these new macros needs to settle down. So the answer is that I considered the explicit definition to be better just to be sure.

Thanks for the help and all the reviews!

Pull-Request has been merged by lbalhar

3 years ago