#1 Move executables from py2 to py3 (#1410332)
Merged 6 years ago by churchyard. Opened 6 years ago by churchyard.
rpms/ churchyard/python-jupyter-core py3executables  into  master

file modified
+16 -25
@@ -4,7 +4,7 @@ 

  

  Name:           python-%{pypi_name_dash}

  Version:        4.3.0

- Release:        1%{?dist}

+ Release:        2%{?dist}

  Summary:        The base package for Jupyter projects

  

  License:        BSD
@@ -53,6 +53,12 @@ 

  

  Requires:       python%{python3_pkgversion}-traitlets

  Requires:       python%{python3_pkgversion}-setuptools

+ 

+ # executables moved from py2 to py3

+ # https://bugzilla.redhat.com/show_bug.cgi?id=1410332

+ # Can be removed in Fedora 30

+ Conflicts:      python2-%{pypi_name_dash} < 4.3.0-2

+ 

  %description -n python%{python3_pkgversion}-%{pypi_name_dash}

  Core common functionality of Jupyter projects.

  
@@ -80,22 +86,12 @@ 

  

  %install

  find | grep pyc$ | xargs rm -v

- # Must do the subpackages' install first because the scripts in /usr/bin are

- # overwritten with every setup.py install.

- %py3_install

- mv %{buildroot}/%{_bindir}/jupyter %{buildroot}/%{_bindir}/jupyter-%{python3_version}

- ln -s jupyter-%{python3_version} %{buildroot}/%{_bindir}/jupyter-3

- mv %{buildroot}/%{_bindir}/jupyter-migrate %{buildroot}/%{_bindir}/jupyter-migrate-%{python3_version}

- ln -s jupyter-migrate-%{python3_version} %{buildroot}/%{_bindir}/jupyter-migrate-3

  

  %py2_install

- mv %{buildroot}/%{_bindir}/jupyter %{buildroot}/%{_bindir}/jupyter-%{python2_version}

- ln -s jupyter-%{python2_version} %{buildroot}/%{_bindir}/jupyter-2

- mv %{buildroot}/%{_bindir}/jupyter-migrate %{buildroot}/%{_bindir}/jupyter-migrate-%{python2_version}

- ln -s jupyter-migrate-%{python2_version} %{buildroot}/%{_bindir}/jupyter-migrate-2

+ rm %{buildroot}%{_bindir}/*

+ 

+ %py3_install

  

- ln -s jupyter-2 %{buildroot}/%{_bindir}/jupyter

- ln -s jupyter-migrate-2 %{buildroot}/%{_bindir}/jupyter-migrate

  

  # Remove shebang from troubleshoot.py

  for lib in %{buildroot}{%{python2_sitelib},%{python3_sitelib}}/jupyter_core/troubleshoot.py; do
@@ -109,13 +105,6 @@ 

  %files -n python2-%{pypi_name_dash}

  %license COPYING.md

  %doc README.md

- %{_bindir}/jupyter

- %{_bindir}/jupyter-2

- %{_bindir}/jupyter-%{python2_version}

- %{_bindir}/jupyter-migrate

- %{_bindir}/jupyter-migrate-2

- %{_bindir}/jupyter-migrate-%{python2_version}

- 

  %{python2_sitelib}/jupyter.py*

  %{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info

  %{python2_sitelib}/%{pypi_name}/
@@ -123,10 +112,9 @@ 

  %files -n python%{python3_pkgversion}-%{pypi_name_dash}

  %license COPYING.md

  %doc README.md

- %{_bindir}/jupyter-3

- %{_bindir}/jupyter-%{python3_version}

- %{_bindir}/jupyter-migrate-3

- %{_bindir}/jupyter-migrate-%{python3_version}

+ %{_bindir}/jupyter

+ %{_bindir}/jupyter-migrate

+ 

  %{python3_sitelib}/__pycache__/*

  %{python3_sitelib}/jupyter.py

  %{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
@@ -136,6 +124,9 @@ 

  %doc html

  

  %changelog

+ * Fri Sep 01 2017 Miro Hrončok <mhroncok@redhat.com> - 4.3.0-2

+ - Move executables from py2 to py3 (#1410332)

+ 

  * Tue Aug 29 2017 Orion Poplawski <orion@cora.nwra.com> - 4.3.0-1

  - Update to 4.3.0

  

Hmm, how does this work on upgrades? Without Obsoletes, you will need --allow-erasing I think.

Come to think of it, by not providing the -3 version of the executable names it may be hard to write Fedora-version agnostic scripts / spec files.

Besides that, LGTM.

Hmm, how does this work on upgrades? Without Obsoletes, you will need --allow-erasing I think.

You think python3-... should obolete python2-... <= 4.3.0-1?

Come to think of it, by not providing the -3 version of the executable names it may be hard to write Fedora-version agnostic scripts / spec files.

pythonX -m ?

< 4.3.0-2 because 1-1 < 1-1.fc27

rebased

6 years ago

I don't think this is needed

Well, it's "explicit is better than implicit"

Removed / after %{buildroot}, amended.

rebased

6 years ago

Pull-Request has been merged by churchyard

6 years ago
Metadata