2b27cc2
@@ -16,6 +16,7 @@
BuildRequires: python3-setuptools_scm
BuildRequires: python3-packaging
BuildRequires: python3-zipp >= 0.5
+ %{?el8:BuildRequires: python3-importlib-resources}
%description
importlib_metadata is a library which provides an API for accessing an
as required by importlib-metadata's setup.cfg
This was discovered by building this package for epel8
python3 is not < 3.7 on Fedora 31.
Generally, buildrequires like this cause problems in Koschei etc. Can it be guarded by %if please?
That means, we need to fix Koschei rather than trying to workaround it. no?
Yes and it has been reported and possible fix has landed in dnf-stack, but in the meantime, we need to workaround that.
1 new commit added
python3-zipp is required at install time, not just build
This shouldn't affect Fedora 31 if python3 is < 3.7 though, right?
python3 is not < 3.7 on Fedora 31. Generally, buildrequires like this cause problems in Koschei etc. Can it be guarded by %if please?
This pull request is not needed on Fedora 31 is what I have meant.
this is handed by automatic runtime dependencies.
this should have not been removed.
add importlib-resources backport if py3 < 3.7
We were hitting issues with the dependency generator not being enabled for epel8. I've undone the changes in reference to that. We still have the python version-dependent requirement for importlib-resources
I don't mind small changes in the Fedora 31 branch to have more similar specs between Fedora and EPEL, but I mind stuff that is not needed.
I think we should use a dist-tag conditional, so that this line will only apply on RHEL 8.
%{?el8:BuildRequires: python3-importlib-resources}
conditionally BuildRequires importlib-resources for EL8 only
@churchyard are you ok with taking this change into f31 now?
f31
(we can squash it down into one commit)
If not, we can diverge the new epel8 branch for this change.
epel8
Sure. Please squash.
rebased onto 2b27cc2
Pull-Request has been closed by jcaratzas
as required by importlib-metadata's setup.cfg
This was discovered by building this package for epel8