From ebea723169afd16487acc8a9df782582921bfb15 Mon Sep 17 00:00:00 2001 From: Paul Howarth Date: Jan 12 2012 19:19:39 +0000 Subject: Drop %defattr, no longer needed --- diff --git a/perl-Perl-Critic.spec b/perl-Perl-Critic.spec index 88c153a..73c9554 100644 --- a/perl-Perl-Critic.spec +++ b/perl-Perl-Critic.spec @@ -1,14 +1,13 @@ Name: perl-Perl-Critic Version: 1.117 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Critique Perl source code for best-practices - Group: Development/Libraries License: GPL+ or Artistic URL: http://search.cpan.org/dist/Perl-Critic/ Source0: http://search.cpan.org/CPAN/authors/id/T/TH/THALJEF/Perl-Critic-%{version}.tar.gz BuildArch: noarch -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) # Build process BuildRequires: perl(Module::Build) @@ -87,7 +86,6 @@ BuildRequires: perl(Test::Without::Module) # don't "provide" private Perl libs %{?perl_default_filter} - %description Perl::Critic is an extensible framework for creating and applying coding standards to Perl source code. Essentially, it is a static source code @@ -99,55 +97,47 @@ even support Policies that contradict Conway. You can enable, disable, and customize those Polices through the Perl::Critic interface. You can also create new Policy modules that suit your own tastes. - %package -n perl-Test-Perl-Critic-Policy Summary: A framework for testing your custom Policies Group: Development/Libraries License: GPL+ or Artistic - %description -n perl-Test-Perl-Critic-Policy This module provides a framework for function-testing your custom Perl::Critic::Policy modules. Policy testing usually involves feeding it a string of Perl code and checking its behavior. In the old days, those strings of Perl code were mixed directly in the test script. That sucked. - %prep %setup -q -n Perl-Critic-%{version} -find . -type f -exec chmod -c -x {} + - +find . -type f -exec chmod -c -x {} ';' %build -%{__perl} Build.PL installdirs=vendor +perl Build.PL installdirs=vendor ./Build - %install -./Build install destdir=$RPM_BUILD_ROOT create_packlist=0 -%{_fixperms} $RPM_BUILD_ROOT - +./Build install destdir=%{buildroot} create_packlist=0 +%{_fixperms} %{buildroot} %check LC_ALL=en_US ./Build %{!?perl_bootstrap:author}test - %files -%defattr(-,root,root,-) %doc Changes LICENSE README TODO.pod examples/ extras/ tools/ %{_bindir}/perlcritic %{perl_vendorlib}/Perl/ %{_mandir}/man1/perlcritic.1* %{_mandir}/man3/Perl::Critic*.3pm* - %files -n perl-Test-Perl-Critic-Policy -%defattr(-,root,root,-) %{perl_vendorlib}/Test/ %{_mandir}/man3/Test::Perl::Critic::Policy.3pm* - %changelog +* Thu Jan 12 2012 Paul Howarth - 1.117-2 +- drop %%defattr, no longer needed + * Thu Dec 22 2011 Paul Howarth - 1.117-1 - update to 1.117 New Policies: