#1 Spec cleanup
Closed 5 years ago by orion. Opened 6 years ago by vascom.
Unknown source master  into  master

file modified
+8 -7
@@ -21,9 +21,8 @@

  Name:           octave

  Epoch:          6

  Version:        4.2.1

- Release:        4%{?rcver:.rc%{rcver}}%{?dist}.2

+ Release:        4%{?rcver:.rc%{rcver}}%{?dist}.3

  Summary:        A high-level language for numerical computations

- Group:          Applications/Engineering

  License:        GPLv3+

  URL:            http://www.octave.org

  
@@ -154,6 +153,7 @@

  Requires:       tex(epsfig.sty)

  Requires:       tex(geometry.sty)

  Requires:       tex(graphicx.sty)

+ Requires:       hicolor-icon-theme

  

  Requires(post): info

  Requires(preun): info
@@ -201,9 +201,7 @@

  This package contains documentation for Octave.

  

  %prep

- %setup -q -n %{name}-%{version}%{?rctag}

- %patch2 -p1 -b .appdata

- %patch4 -p1 -b .gnulib

+ %autosetup -p1 -n %{name}-%{version}%{?rctag}

  # __osmesa_print__ test is triggering a crash in libgcc, disable it

  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78409

  #sed -i -e '/^%!/d' libinterp/dldfcn/__osmesa_print__.cc
@@ -268,10 +266,10 @@

    exit 1

  fi

  

- make OCTAVE_RELEASE="Fedora %{version}%{?rctag}-%{release}" %{?_smp_mflags}

+ %make_build OCTAVE_RELEASE="Fedora %{version}%{?rctag}-%{release}"

  

  %install

- make install DESTDIR=%{buildroot}

+ %make_install

  

  # Docs - In case we didn't build them and to explicitly install pre-built docs

  make install-data install-html install-info install-pdf DESTDIR=%{buildroot}
@@ -448,6 +446,9 @@

  %{_pkgdocdir}/refcard*.pdf

  

  %changelog

+ * Fri Sep 08 2017 Vasiliy N. Glazov <vascom2@gmail.com> - 6:4.2.1-4.3

+ - Cleanup spec

+ 

  * Sun Aug 12 2017 Orion Poplawski <orion@cora.nwra.com> - 6:4.2.1-4.2

  - Make octave-devel require libappstream-glib

  

I hope this cleanup changes can make spec file more simple and accurate with Fedora packaging guidelines.

Thanks. I've applied most of the changes.

Pull-Request has been closed by orion

5 years ago
Metadata