Does this just blindly update typescript to the latest version, or does it ensure that no other NodeJS packages that depend on typescript are broken by updating this package?

I'm not well versed in the NodeJS ecosystem, so I haven't tested compatibility with other packages. My motivation is I am trying to package the pop shell GNOME extension, which requires at least TypeScript 3.8 to build.

https://github.com/pop-os/shell/blob/master_focal/README.md#installation

I understand the concern about compatibility, but I think this is appropriate for Rawhide, hence the pull request being against the master branch. We're currently shipping version 2.8.3, which was released upstream on 2018-04-19. Shipping a 2+ year old version directly contradicts with Fedora's First Foundation. Considering that TypeScript 3 was released on 2018-07-06, and TypeScript 4 claims to have "no larger breaking changes than usual", I imagine most of the NodeJS ecosystem is already compatible. I think we should push this for Rawhide to move our NodeJS package ecosystem forward.

OK, then we can use this as a teaching/learning experience. :-)

To check to see what other packages depend on nodejs-typescript, run the following command:

$ dnf repoquery --repo=rawhide-source --whatrequires 'npm(typescript)' --alldeps --quiet

For each package that depends on 'npm(typescript)', check and see if they depend on a particular version by running the following command. (I'm doing the first -- I'll let you check any others).

$ dnf repoquery --repo=rawhide-source --requires nodejs-locate-character --quiet

Now check the output of that command and see if the version of typescript is set to any particular version. In this case, it's not.

Please check any other packages that have dependencies on 'npm(typescript)' and let me know.

Also, your patch removes any tests from the package, and throws several errors and warnings in rpmlint, so you'll want to check those as well. (If you need help with any of them or don't understand what to do, please don't hesitate to ask for help on this ticket.)

Please check any other packages that have dependencies on 'npm(typescript)' and let me know.

The only other one is nodejs-rollup-plugin-typescript, which also doesn't specify any restrictions on the typescript version.

I took this a step further and attempted to do local rebuilds of those two packages with this typescript build. They both worked in an F32 mock. I wasn't able to test F33 or F34 because both have build requirements on mocha, which is currently uninstallable on F33/F34 due to nodejs-supports-color being retired. Additionally, nodejs-rollup-plugin-typescript has a build requirement on nodejs-rollup, which is also retired on F33/F34.

Also, your patch removes any tests from the package

The tests weren't being run before. Upstream doesn't use a Jakefile anymore, so running the tests in the future will require %check to be overhauled, in addition to packaging all the missing test requirements. Better to clean it up now and start fresh in the future if/when all the test requirements are packaged.

and throws several errors and warnings in rpmlint, so you'll want to check those as well.

rpmlint warnings before the pull request:

nodejs-typescript.spec:17: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 17)
nodejs-typescript.spec: W: invalid-url Source4: scripts-2.8.3.tar.bz2
nodejs-typescript.spec: W: invalid-url Source3: docs-2.8.3.tar.bz2
nodejs-typescript.spec: W: invalid-url Source2: src-2.8.3.tar.bz2
nodejs-typescript.spec: W: invalid-url Source1: tests-2.8.3.tar.bz2
0 packages and 1 specfiles checked; 0 errors, 5 warnings.

rpmlint warnings after the pull request:

nodejs-typescript.spec: W: no-%build-section
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

It is standard practice to remove empty %build sections, so I think this is fine.

bump @jsmith @zvetlik @galileo @vjancik - could we make this happen?

❤️❤️❤️