PR#1: Add BuildRequires: nodejs(engine) to spec - rpms/nodejs-colors

rpms / nodejs-colors

#1 Add BuildRequires: nodejs(engine) to spec

Merged 3 years ago by tdawson. Opened 3 years ago by tdawson.

rpms/ tdawson/nodejs-colors master into master

Add BuildRequires: nodejs(engine) to spec

Troy Dawson • 3 years ago

12f5dcd

nodejs-colors.spec

file modified

		`@@ -14,6 +14,7 @@`
		`ExclusiveArch: %{nodejs_arches} noarch`

		`BuildRequires: nodejs-packaging`
		`+ BuildRequires: nodejs(engine)`

		`%description`
		`%{summary}.`

tdawson commented 3 years ago

nodejs-packaging was recently updated to not require nodejs(engine).
This was done to break a circular dependency.
This package has nothing else that would pull nodejs in during a build.
Adding "BuildRequires: nodejs(engine)" to spec so it will build on Rawhide (f33) and beyond.

Signed-off-by: Troy Dawson tdawson@redhat.com

tdawson commented 3 years ago

Please respond one way or another within a week.
The ELN project is on a modest time schedule.
Since this is a minor change, that allows the package to successfully build in Rawhide and ELN, if we do not hear any response in a week, we will have a proven packager merge this pull request.

tdawson commented 3 years ago

proven packager merging pull request.

Pull-Request has been merged by tdawson

3 years ago