b4d0d93
--- net-tools-1.60/ifconfig.c.new	2005-07-20 12:47:29.000000000 +0200
b4d0d93
+++ net-tools-1.60/ifconfig.c	2005-07-20 12:54:57.000000000 +0200
b4d0d93
@@ -175,6 +175,32 @@
b4d0d93
     return (0);
b4d0d93
 }
b4d0d93
 
b4d0d93
+/** test is a specified flag is set */
b4d0d93
+static int test_flag(char *ifname, short flags)
b4d0d93
+{
b4d0d93
+    struct ifreq ifr;
b4d0d93
+    int fd;
b4d0d93
+
b4d0d93
+    if (strchr(ifname, ':')) {
b4d0d93
+        /* This is a v4 alias interface.  Downing it via a socket for
b4d0d93
+	   another AF may have bad consequences. */
b4d0d93
+        fd = get_socket_for_af(AF_INET);
b4d0d93
+	if (fd < 0) {
b4d0d93
+	    fprintf(stderr, _("No support for INET on this system.\n"));
b4d0d93
+	    return -1;
b4d0d93
+	}
b4d0d93
+    } else
b4d0d93
+        fd = skfd;
b4d0d93
+
b4d0d93
+    safe_strncpy(ifr.ifr_name, ifname, IFNAMSIZ);
b4d0d93
+    if (ioctl(fd, SIOCGIFFLAGS, &ifr) < 0) {
b4d0d93
+	fprintf(stderr, _("%s: ERROR while testing interface flags: %s\n"), 
b4d0d93
+		ifname, strerror(errno));
b4d0d93
+	return -1;
b4d0d93
+    }
b4d0d93
+    return (ifr.ifr_flags & flags);
b4d0d93
+}
b4d0d93
+
b4d0d93
 static void usage(void)
b4d0d93
 {
b4d0d93
     fprintf(stderr, _("Usage:\n  ifconfig [-a] [-v] [-s] <interface> [[<AF>] <address>]\n"));
b4d0d93
@@ -249,7 +275,7 @@
b4d0d93
 			err = 1;
b4d0d93
     	}
b4d0d93
     }
b4d0d93
-    return 0;
b4d0d93
+    return err;
b4d0d93
 }
b4d0d93
 
b4d0d93
 int main(int argc, char **argv)
b4d0d93
@@ -415,6 +441,8 @@
b4d0d93
 	}
b4d0d93
 	if (!strcmp(*spp, "-promisc")) {
b4d0d93
 	    goterr |= clr_flag(ifr.ifr_name, IFF_PROMISC);
b4d0d93
+	    if (test_flag(ifr.ifr_name, IFF_PROMISC) > 0)
b4d0d93
+	    	fprintf(stderr, _("Warning: Interface %s still in promisc mode... maybe other application is running?\n"), ifr.ifr_name);
b4d0d93
 	    spp++;
b4d0d93
 	    continue;
b4d0d93
 	}
b4d0d93
@@ -425,6 +453,8 @@
b4d0d93
 	}
b4d0d93
 	if (!strcmp(*spp, "-multicast")) {
b4d0d93
 	    goterr |= clr_flag(ifr.ifr_name, IFF_MULTICAST);
b4d0d93
+	    if (test_flag(ifr.ifr_name, IFF_MULTICAST) > 0)
b4d0d93
+	    	fprintf(stderr, _("Warning: Interface %s still in MULTICAST mode.\n"), ifr.ifr_name);
b4d0d93
 	    spp++;
b4d0d93
 	    continue;
b4d0d93
 	}
b4d0d93
@@ -435,6 +465,8 @@
b4d0d93
 	}
b4d0d93
 	if (!strcmp(*spp, "-allmulti")) {
b4d0d93
 	    goterr |= clr_flag(ifr.ifr_name, IFF_ALLMULTI);
b4d0d93
+	    if (test_flag(ifr.ifr_name, IFF_MULTICAST) > 0)
b4d0d93
+	    	fprintf(stderr, _("Warning: Interface %s still in ALLMULTI mode.\n"), ifr.ifr_name);
b4d0d93
 	    spp++;
b4d0d93
 	    continue;
b4d0d93
 	}
b4d0d93
@@ -456,6 +488,8 @@
b4d0d93
 	}
b4d0d93
 	if (!strcmp(*spp, "-dynamic")) {
b4d0d93
 	    goterr |= clr_flag(ifr.ifr_name, IFF_DYNAMIC);
b4d0d93
+	    if (test_flag(ifr.ifr_name, IFF_MULTICAST) > 0)
b4d0d93
+	    	fprintf(stderr, _("Warning: Interface %s still in DYNAMIC mode.\n"), ifr.ifr_name);
b4d0d93
 	    spp++;
b4d0d93
 	    continue;
b4d0d93
 	}
b4d0d93
@@ -513,6 +547,8 @@
b4d0d93
 
b4d0d93
 	if (!strcmp(*spp, "-broadcast")) {
b4d0d93
 	    goterr |= clr_flag(ifr.ifr_name, IFF_BROADCAST);
b4d0d93
+	    if (test_flag(ifr.ifr_name, IFF_MULTICAST) > 0)
b4d0d93
+	    	fprintf(stderr, _("Warning: Interface %s still in BROADCAST mode.\n"), ifr.ifr_name);
b4d0d93
 	    spp++;
b4d0d93
 	    continue;
b4d0d93
 	}
b4d0d93
@@ -569,7 +605,7 @@
b4d0d93
 		continue;
b4d0d93
 	    }
b4d0d93
 	    didnetmask++;
b4d0d93
-	    goterr = set_netmask(ap->fd, &ifr, &sa, dobcast);
b4d0d93
+	    goterr |= set_netmask(ap->fd, &ifr, &sa, dobcast);
b4d0d93
 	    spp++;
b4d0d93
 	    continue;
b4d0d93
 	}
b4d0d93
@@ -640,6 +676,8 @@
b4d0d93
 	}
b4d0d93
 	if (!strcmp(*spp, "-pointopoint")) {
b4d0d93
 	    goterr |= clr_flag(ifr.ifr_name, IFF_POINTOPOINT);
b4d0d93
+	    if (test_flag(ifr.ifr_name, IFF_MULTICAST) > 0)
b4d0d93
+	    	fprintf(stderr, _("Warning: Interface %s still in POINTOPOINT mode.\n"), ifr.ifr_name);
b4d0d93
 	    spp++;
b4d0d93
 	    continue;
b4d0d93
 	}