|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
From 599f25e51d967febddb4de3aa21db4258356a9f9 Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
From: Owen W. Taylor <otaylor@fishsoup.net>
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
Date: Fri, 20 Nov 2009 10:19:03 -0500
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
Subject: [PATCH] Accept an empty string as well as "disabled" for keybindings
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
Treat the empty string the same as "disabled" for GConf keybinding
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
keys. gnome-keybinding-properties was changed to write disabled
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
keys as the empty string a year or so ago.
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
https://bugzilla.gnome.org/show_bug.cgi?id=559816
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
---
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
src/ui/ui.c | 4 ++--
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
1 files changed, 2 insertions(+), 2 deletions(-)
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
diff --git a/src/ui/ui.c b/src/ui/ui.c
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
index 6df289f..1e68df0 100644
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
--- a/src/ui/ui.c
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
+++ b/src/ui/ui.c
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
@@ -765,7 +765,7 @@ meta_ui_parse_accelerator (const char *accel,
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
*keycode = 0;
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
*mask = 0;
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
- if (strcmp (accel, "disabled") == 0)
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
+ if (!accel[0] || strcmp (accel, "disabled") == 0)
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
return TRUE;
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
meta_ui_accelerator_parse (accel, &gdk_sym, &gdk_code, &gdk_mask);
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
@@ -852,7 +852,7 @@ meta_ui_parse_modifier (const char *accel,
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
*mask = 0;
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
- if (accel == NULL || strcmp (accel, "disabled") == 0)
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
+ if (accel == NULL || !accel[0] || strcmp (accel, "disabled") == 0)
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
return TRUE;
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
meta_ui_accelerator_parse (accel, &gdk_sym, &gdk_code, &gdk_mask);
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
--
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
1.6.5.2
|
|
![](https://seccdn.libravatar.org/avatar/df8d3cb0cdb8c2542f60cdebbd721dfda6e8a48e0276926ba4922134df82034b?s=16&d=retro) |
97b0323 |
|