a03d891
From c08b73d7183e2dbab0ba43c3df32f4214abbc9c6 Mon Sep 17 00:00:00 2001
a03d891
From: Petr Lautrbach <plautrba@redhat.com>
a03d891
Date: Fri, 9 Oct 2020 15:00:51 +0200
a03d891
Subject: [PATCH] libsemanage: Drop deprecated functions
a03d891
a03d891
semanage_module_enable() and semanage_module_disable() were deprecated
a03d891
by commit 9fbc6d14418f ("libsemanage: add back original module
a03d891
enable/disable functions for ABI compatability") in 2014 in order to
a03d891
preserve ABI compatibility. As we the libsemanage ABI is changed by the
a03d891
previous commit, it makes sense to drop them completely.
a03d891
a03d891
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
a03d891
---
a03d891
 libsemanage/src/libsemanage.map |  2 --
a03d891
 libsemanage/src/modules.c       | 56 ---------------------------------
a03d891
 2 files changed, 58 deletions(-)
a03d891
a03d891
diff --git a/libsemanage/src/libsemanage.map b/libsemanage/src/libsemanage.map
a03d891
index 4bec06aaae27..3ea7b60f97bb 100644
a03d891
--- a/libsemanage/src/libsemanage.map
a03d891
+++ b/libsemanage/src/libsemanage.map
a03d891
@@ -165,8 +165,6 @@ LIBSEMANAGE_1.0 {
a03d891
     semanage_is_connected;
a03d891
     semanage_is_managed;
a03d891
     semanage_mls_enabled;
a03d891
-    semanage_module_disable;
a03d891
-    semanage_module_enable;
a03d891
     semanage_module_get_name;
a03d891
     semanage_module_get_version;
a03d891
     semanage_module_info_datum_destroy;
a03d891
diff --git a/libsemanage/src/modules.c b/libsemanage/src/modules.c
a03d891
index 8b36801038df..b6dd456cac32 100644
a03d891
--- a/libsemanage/src/modules.c
a03d891
+++ b/libsemanage/src/modules.c
a03d891
@@ -734,62 +734,6 @@ int semanage_module_set_enabled(semanage_handle_t *sh,
a03d891
 }
a03d891
 
a03d891
 
a03d891
-/* This function exists only for ABI compatibility. It has been deprecated and
a03d891
- * should not be used. Instead, use semanage_module_set_enabled() */
a03d891
-int semanage_module_enable(semanage_handle_t *sh, char *module_name)
a03d891
-{
a03d891
-	int rc = -1;
a03d891
-	semanage_module_key_t *modkey = NULL;
a03d891
-
a03d891
-	rc = semanage_module_key_create(sh, &modkey);
a03d891
-	if (rc != 0)
a03d891
-		goto exit;
a03d891
-
a03d891
-	rc = semanage_module_key_set_name(sh, modkey, module_name);
a03d891
-	if (rc != 0)
a03d891
-		goto exit;
a03d891
-
a03d891
-	rc = semanage_module_set_enabled(sh, modkey, 1);
a03d891
-	if (rc != 0)
a03d891
-		goto exit;
a03d891
-
a03d891
-	rc = 0;
a03d891
-
a03d891
-exit:
a03d891
-	semanage_module_key_destroy(sh, modkey);
a03d891
-	free(modkey);
a03d891
-
a03d891
-	return rc;
a03d891
-}
a03d891
-
a03d891
-/* This function exists only for ABI compatibility. It has been deprecated and
a03d891
- * should not be used. Instead, use semanage_module_set_enabled() */
a03d891
-int semanage_module_disable(semanage_handle_t *sh, char *module_name)
a03d891
-{
a03d891
-	int rc = -1;
a03d891
-	semanage_module_key_t *modkey = NULL;
a03d891
-
a03d891
-	rc = semanage_module_key_create(sh, &modkey);
a03d891
-	if (rc != 0)
a03d891
-		goto exit;
a03d891
-
a03d891
-	rc = semanage_module_key_set_name(sh, modkey, module_name);
a03d891
-	if (rc != 0)
a03d891
-		goto exit;
a03d891
-
a03d891
-	rc = semanage_module_set_enabled(sh, modkey, 0);
a03d891
-	if (rc != 0)
a03d891
-		goto exit;
a03d891
-
a03d891
-	rc = 0;
a03d891
-
a03d891
-exit:
a03d891
-	semanage_module_key_destroy(sh, modkey);
a03d891
-	free(modkey);
a03d891
-
a03d891
-	return rc;
a03d891
-}
a03d891
-
a03d891
 /* Converts a string to a priority
a03d891
  *
a03d891
  * returns -1 if str is not a valid priority.
a03d891
-- 
a03d891
2.29.0
a03d891