PR#2: miscellaneous fixes and cleanups - rpms/libgpod

rpms / libgpod

#2 miscellaneous fixes and cleanups

Merged 5 years ago by limb. Opened 5 years ago by tmz.

rpms/ tmz/libgpod master into master

Add rpmlint config

Todd Zullinger • 5 years ago

44edccf

Fix mode of /run/libgpod in tmpfiles.d config, use /run consistently

Todd Zullinger • 5 years ago

d14dae0

libgpod.rpmlintrc

file added

+16

		`@@ -0,0 +1,16 @@`
		`+ from Config import addFilter`
		`+`
		`+ # libgpod is unlikely to be updated to fix the license file`
		`+ addFilter("incorrect-fsf-address .*/COPYING")`
		`+`
		`+ # the README.SysInfo file documents the usage of this command`
		`+ addFilter("libgpod.*: W: no-manual-page-for-binary ipod-read-sysinfo-extended")`
		`+`
		`+ # documention is in libgpod-doc`
		`+ addFilter("libgpod-(devel\|sharp).*: W: no-documentation")`
		`+`
		`+ # only-non-binary-in-usr-lib is expected for mono packages`
		`+ addFilter("libgpod-sharp.*: W: only-non-binary-in-usr-lib")`
		`+`
		`+ # ignore spelling errors`
		`+ addFilter("libgpod.: W: spelling-error %description . (playlists\|playcounts\|podcasts)")`

libgpod.spec

file modified

+5 -4

		`@@ -13,7 +13,7 @@`
		`Summary: Library to access the contents of an iPod`
		`Name: libgpod`
		`Version: 0.8.3`
		`- Release: 25%{?dist}`
		`+ Release: 26%{?dist}`
		`License: LGPLv2+`
		`URL: http://www.gtkpod.org/libgpod.html`
		`Source0: http://downloads.sourceforge.net/gtkpod/%{name}-%{version}.tar.bz2`
		`@@ -146,10 +146,8 @@`

		`# Setup tmpfiles.d config`
		`mkdir -p %{buildroot}%{_tmpfilesdir}`
		`- echo "D /var/run/%{name} 0644 root root -" > \`
		`- %{buildroot}%{_tmpfilesdir}/%{name}.conf`
		`+ echo "D /run/%{name} - - - -" > %{buildroot}%{_tmpfilesdir}/%{name}.conf`

		`- mkdir -p %{buildroot}/run`
		`install -d -m 0755 %{buildroot}/run/%{name}/`

		`# remove static libs and libtool archives`
		`@@ -192,6 +190,9 @@`
		`%endif`

		`%changelog`
		`+ * Wed Oct 03 2018 Todd Zullinger <tmz@pobox.com> - 0.8.3-26`
		`+ - Fix mode of /run/libgpod in tmpfiles.d config, use /run`
		`+`
		`* Fri Sep 28 2018 Gwyn Ciesla <limburgher@gmail.com> - 0.8.3-25`
		`- Drop python2.`

tmz commented 5 years ago

Hi,

While running rpm -V I noticed that /run/libgpod showed a mode change. The tmpfiles.d config was inadvertently creating the dir with a mode of 0644. After fixing that and building locally, I fixed the deprecation warnings caused by allowing the build scripts to use /usr/bin/python for the python bindings. Lastly, I cleaned up the remaining rpmlint warnings (apart from one which is noted as an rpmlint issue that I'll fix in rpmlint).

Thanks.

rebased onto dee237f

5 years ago

limb commented 5 years ago

This needs another rebase but I think it's sound.

rebased onto 973074e

5 years ago

rebased onto d14dae0

5 years ago

tmz commented 5 years ago

Thanks for spotting this @limb. I was worried it had fallen through the cracks completely. ;)

I've rebased against the current master, dropping the python2 commit which was separately added by Christophe and then made obsolete when the python2-gpod subpackage was dropped.

I checked rpmlint is still clean and updated the commit message, as only the rpmlintrc was added now that there are no python files which need fixed in the spec file.

After looking at this again, I decided to drop the use of %{_rundir} as /run is all the guidelines recommend. So the single use of /var/run in the tmpdfiles.d config file is the only path changed. (I made that change after the scratch build I used to test with rpmlint, so hopefully I didn't introduced any errors.)

With the python subpackage dropped, I've got no reason to use libgpod anymore, so I probably won't have much reason to use or test it in the future -- unless I get really bored and work on porting it to python3, but that's probably unlikely. :)