|
 |
e952f8d |
From 8312eaa576014cd9b965012af51bc1f967b12423 Mon Sep 17 00:00:00 2001
|
|
|
e952f8d |
From: Daniel Axtens <dja@axtens.net>
|
|
|
e952f8d |
Date: Tue, 1 Jan 2019 17:10:49 +1100
|
|
|
e952f8d |
Subject: [PATCH 1/2] iso9660: Fail when expected Rockridge extensions is
|
|
|
e952f8d |
missing
|
|
|
e952f8d |
|
|
|
e952f8d |
A corrupted or malicious ISO9660 image can cause read_CE() to loop
|
|
|
e952f8d |
forever.
|
|
|
e952f8d |
|
|
|
e952f8d |
read_CE() calls parse_rockridge(), expecting a Rockridge extension
|
|
|
e952f8d |
to be read. However, parse_rockridge() is structured as a while
|
|
|
e952f8d |
loop starting with a sanity check, and if the sanity check fails
|
|
|
e952f8d |
before the loop has run, the function returns ARCHIVE_OK without
|
|
|
e952f8d |
advancing the position in the file. This causes read_CE() to retry
|
|
|
e952f8d |
indefinitely.
|
|
|
e952f8d |
|
|
|
e952f8d |
Make parse_rockridge() return ARCHIVE_WARN if it didn't read an
|
|
|
e952f8d |
extension. As someone with no real knowledge of the format, this
|
|
|
e952f8d |
seems more apt than ARCHIVE_FATAL, but both the call-sites escalate
|
|
|
e952f8d |
it to a fatal error immediately anyway.
|
|
|
e952f8d |
|
|
|
e952f8d |
Found with a combination of AFL, afl-rb (FairFuzz) and qsym.
|
|
|
e952f8d |
---
|
|
|
e952f8d |
libarchive/archive_read_support_format_iso9660.c | 11 ++++++++++-
|
|
|
e952f8d |
1 file changed, 10 insertions(+), 1 deletion(-)
|
|
|
e952f8d |
|
|
|
e952f8d |
diff --git a/libarchive/archive_read_support_format_iso9660.c b/libarchive/archive_read_support_format_iso9660.c
|
|
|
e952f8d |
index 28acfefb..bad8f1df 100644
|
|
|
e952f8d |
--- a/libarchive/archive_read_support_format_iso9660.c
|
|
|
e952f8d |
+++ b/libarchive/archive_read_support_format_iso9660.c
|
|
|
e952f8d |
@@ -2102,6 +2102,7 @@ parse_rockridge(struct archive_read *a, struct file_info *file,
|
|
|
e952f8d |
const unsigned char *p, const unsigned char *end)
|
|
|
e952f8d |
{
|
|
|
e952f8d |
struct iso9660 *iso9660;
|
|
|
e952f8d |
+ int entry_seen = 0;
|
|
|
e952f8d |
|
|
|
e952f8d |
iso9660 = (struct iso9660 *)(a->format->data);
|
|
|
e952f8d |
|
|
|
e952f8d |
@@ -2257,8 +2258,16 @@ parse_rockridge(struct archive_read *a, struct file_info *file,
|
|
|
e952f8d |
}
|
|
|
e952f8d |
|
|
|
e952f8d |
p += p[2];
|
|
|
e952f8d |
+ entry_seen = 1;
|
|
|
e952f8d |
+ }
|
|
|
e952f8d |
+
|
|
|
e952f8d |
+ if (entry_seen)
|
|
|
e952f8d |
+ return (ARCHIVE_OK);
|
|
|
e952f8d |
+ else {
|
|
|
e952f8d |
+ archive_set_error(&a->archive, ARCHIVE_ERRNO_FILE_FORMAT,
|
|
|
e952f8d |
+ "Tried to parse Rockridge extensions, but none found");
|
|
|
e952f8d |
+ return (ARCHIVE_WARN);
|
|
|
e952f8d |
}
|
|
|
e952f8d |
- return (ARCHIVE_OK);
|
|
|
e952f8d |
}
|
|
|
e952f8d |
|
|
|
e952f8d |
static int
|
|
|
e952f8d |
--
|
|
|
e952f8d |
2.20.1
|
|
|
e952f8d |
|