#3 Add jmock-junit4.13.patch to fix test failure with junit4.13
Merged 3 years ago by decathorpe. Opened 3 years ago by jjames.
rpms/ jjames/jmock master  into  master

@@ -0,0 +1,14 @@ 

+ --- a/jmock-junit4/src/test/java/org/jmock/test/acceptance/junit4/JUnit4TestRunnerTests.java

+ +++ b/jmock-junit4/src/test/java/org/jmock/test/acceptance/junit4/JUnit4TestRunnerTests.java

+ @@ -47,9 +47,8 @@ public class JUnit4TestRunnerTests exten

+      public void testDetectsNonPublicBeforeMethodsCorrectly() {

+          listener.runTestIn(JUnit4TestWithNonPublicBeforeMethod.class);

+          listener.assertTestFailedWith(Throwable.class);

+ -        assertEquals("should have detected non-public before method",

+ -                "Method before() should be public",

+ -                       listener.failure.getMessage());

+ +	assertTrue("should have detected non-public before method",

+ +		listener.failure.getMessage().contains("Method before() should be public"));

+      }

+      

+      public void testAutoInstantiatesMocks() {

file modified
+8 -2
@@ -1,11 +1,14 @@ 

  Name:           jmock

  Version:        2.12.0

- Release:        1%{?dist}

+ Release:        2%{?dist}

  Summary:        Java library for testing code with mock objects

  License:        BSD

  

  URL:            http://www.jmock.org/

  Source0:        https://github.com/jmock-developers/jmock-library/archive/%{version}/%{name}-%{version}.tar.gz

+ # Adapt to junit 4.13

+ # See https://github.com/jmock-developers/jmock-library/pull/200

+ Patch0:         %{name}-junit4.13.patch

  

  BuildArch:      noarch

  
@@ -108,7 +111,7 @@ 

  

  

  %prep

- %setup -q -n %{name}-library-%{version}

+ %autosetup -p1 -n %{name}-library-%{version}

  

  # remove unnecessary dependency on parent POM

  %pom_remove_parent
@@ -158,6 +161,9 @@ 

  

  

  %changelog

+ * Sat Aug 15 2020 Jerry James <loganjerry@gmail.com> - 2.12.0-2

+ - Add jmock-junit4.13.patch to fix test failure with junit4.13

+ 

  * Tue Jul 28 2020 Fabio Valentini <decathorpe@gmail.com> - 2.12.0-1

  - Update to version 2.12.0.

  

no initial comment

simple-koji-ci passed, so I guess it really does fix the test suite failure :-) Thanks!

Pull-Request has been merged by decathorpe

3 years ago