#1 Update Python 2 dependency declarations to new packaging standards
Closed 6 years ago by dcallagh. Opened 6 years ago by ishcherb.
rpms/ ishcherb/greenwave pyambiguous  into  master

file modified
+11 -7
@@ -3,7 +3,7 @@ 

  

  Name:           greenwave

  Version:        0.6.0

- Release:        2%{?dist}

+ Release:        3%{?dist}

  Summary:        Service for gating on automated tests

  License:        GPLv2+

  URL:            https://pagure.io/greenwave
@@ -22,8 +22,8 @@ 

  %if 0%{?fedora} || 0%{?rhel} > 7

  BuildRequires:  python2-setuptools

  BuildRequires:  python2-sphinx

- BuildRequires:  python-sphinxcontrib-httpdomain

- BuildRequires:  python-sphinxcontrib-issuetracker

+ BuildRequires:  python2-sphinxcontrib-httpdomain

+ BuildRequires:  python2-sphinxcontrib-issuetracker

  BuildRequires:  python2-flask

  BuildRequires:  python2-pytest

  BuildRequires:  python2-requests
@@ -35,8 +35,8 @@ 

  %endif

  %{?systemd_requires}

  BuildRequires:  systemd

- BuildRequires:  PyYAML

- BuildRequires:  python-dogpile-cache

+ BuildRequires:  python2-pyyaml

+ BuildRequires:  python2-dogpile-cache

  BuildRequires:  fedmsg

  BuildArch:      noarch

  %if 0%{?fedora} || 0%{?rhel} > 7
@@ -46,8 +46,8 @@ 

  Requires:  python-flask

  Requires:  python-requests

  %endif

- Requires:  PyYAML

- Requires:  python-dogpile-cache

+ Requires:  python2-pyyaml

+ Requires:  python2-dogpile-cache

  Requires:  fedmsg

  

  %description
@@ -102,6 +102,10 @@ 

  %systemd_postun_with_restart %{name}.service

  

  %changelog

+ * Tue Feb 20 2018 Iryna Shcherbina <ishcherb@redhat.com> - 0.6.0-3

+ - Update Python 2 dependency declarations to new packaging standards

+   (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3)

+ 

  * Fri Feb 16 2018 Ralph Bean <rbean@redhat.com> - 0.6.0-2

  - Rebase Fedora specific patches onto the new release.

  

This package uses names with ambiguous python- prefix in requirements.

According to Fedora Packaging guidelines for Python, packages must use names with either python2- or python3- prefix in requirements where available.
We are aiming to rename python-* dependencies to python2-*, so we can later switch the python-* namespace to Python 3.

This PR is part of Fedora's Switch to Python 3 effort.

Note that, although this PR was created automatically, we will respond to any comments or issues which you might find with it. We will keep the PR open for review for a week, and if there's no feedback we'll merge it. There is no need to build the package right after merge, this change can wait for the next package rebuild.
The local mock build passed, for Koji scratch build please see simple-koji-ci result.

Note: please do not backport this to f26, f27 branches, as some of the modified requirements are not available there

This PR was opened automatically, for source code see here

We prefer to keep a single branch shared across F26-rawhide. So I won't apply this as is, unless the new deps are available back to F26. Otherwise I would rather add conditionals which we can gradually phase out.

I've posted a modified version of this patch, with conditionals added, to the upstream git repo here:
https://pagure.io/greenwave/pull-request/131

We will update dist-git to match, once that's merged upstream. So I will reject this PR now. Thanks for filing it though.

Pull-Request has been closed by dcallagh

6 years ago

Thanks for filing an upstream PR!