PR#2: Add weak dependencies on optional storage providers. - rpms/gnucash

rpms / gnucash

#2 Add weak dependencies on optional storage providers.

Closed 3 years ago by notting. Opened 3 years ago by mavit.

rpms/ mavit/gnucash master into master

Suggest, don't Recommend.

Peter Oliver • 3 years ago

1bfdafe

Add weak dependencies on optional storage providers.

Peter Oliver • 3 years ago

eafbce6

gnucash.spec

file modified

+7 -1

		`@@ -2,7 +2,7 @@`
		`Summary: Finance management application`
		`Version: 3.10`
		`URL: http://gnucash.org/`
		`- Release: 3%{?dist}`
		`+ Release: 4%{?dist}`
		`License: GPLv2+`
		`Source: http://downloads.sourceforge.net/sourceforge/gnucash/gnucash-%{version}.tar.bz2`
		`Patch0: gnucash-glib-warnings.patch`
		`@@ -36,6 +36,9 @@`
		`Requires: gnucash-docs >= %{version}`
		`Requires: dconf`
		`Requires: perl(Finance::Quote)`
		`+ Suggests: libdbi-dbd-mysql`
		`+ Suggests: libdbi-dbd-pgsql`
		`+ Suggests: libdbi-dbd-sqlite`

		`%description`
		`GnuCash is a personal finance manager. A check-book like register GUI`
		`@@ -94,6 +97,9 @@`
		`%config(noreplace) %{_sysconfdir}/gnucash/*`

		`%changelog`
		`+ * Mon Jun 1 2020 Peter Oliver <rpm@mavit.org.uk> - 3.10-4`
		`+ - Add weak dependencies on optional storage providers.`
		`+`
		`* Tue May 26 2020 Miro Hrončok <mhroncok@redhat.com> - 3.10-3`
		`- Rebuilt for Python 3.9`

mavit commented 3 years ago

This makes it easier for users to discover how to enable these optional GnuCash features.

notting commented 3 years ago

I don't like the idea of increasing the intalled space & libraries just to make it more 'discoverable' ; seems like the wrong way to go about it.

mavit commented 3 years ago

On my machine, yum remove gnucash would save about 134 MB, whereas yum install libdbi-dbd-sqlite consumes about 700 KB. Half of one percent doesn’t seem excessive to me.

Still, I’ll push a version with only Suggests. As I understand it, the only effect of adding Suggests is to enable things like yum repoquery --suggests ….

1 new commit added

Suggest, don't Recommend.

3 years ago

notting commented 3 years ago

I was more concerned about the database libraries themselves, rather than the libdbi interfaces.
After looking, they're not that big... and they are mostly brought in by the webcam app. Because of course that makes sense.

Can you just force-push the original version and I'll merge that?

mavit commented 3 years ago

It turns out that forced pushes are blocked, and I can't find a setting to change that. Could you cherry-pick eafbce6 from the command line instead?

notting commented 3 years ago

Manually applied, building now for rawhide.