From 3e2b0c41bb3346b0c2f503ce48838f1884692473 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Aug 30 2008 01:33:44 +0000 Subject: plug a memory leak --- diff --git a/gnome-applets.spec b/gnome-applets.spec index 8107b2a..b2948b0 100644 --- a/gnome-applets.spec +++ b/gnome-applets.spec @@ -35,7 +35,7 @@ Summary: Small applications for the GNOME panel Name: gnome-applets Version: 2.23.90 -Release: 1%{?dist} +Release: 2%{?dist} Epoch: 1 License: GPLv2+ and GFDL Group: User Interface/Desktops @@ -64,6 +64,9 @@ Patch39: gweather-network.patch # do the nullapplet dance for battstat Patch40: gnome-applets-null-battstat.patch +# http://bugzilla.gnome.org/show_bug.cgi?id=549890 +Patch41: keyboard-applet-leak.patch + BuildRequires: glib2-devel >= %{glib2_version} BuildRequires: gtk2-devel >= %{gtk2_version} BuildRequires: libgnomeui-devel >= %{libgnomeui_version} @@ -149,6 +152,7 @@ small utilities for the GNOME panel. %patch33 -p1 -b .node-leak %patch39 -p1 -b .gweather-network %patch40 -p1 -b .battstat-null +%patch41 -p1 -b .keyboard-applet-leak # We don't ship gnome-system-tools rm -rf modemlights @@ -308,6 +312,9 @@ fi %{_datadir}/PolicyKit/policy/org.gnome.cpufreqselector.policy %changelog +* Fri Aug 29 2008 Matthias Clasen - 1:2.23.90-2 +- Plug a memory leak in the keyboard applet + * Fri Aug 22 2008 Matthias Clasen - 1:2.23.90-1 - Update to 2.23.90 diff --git a/keyboard-applet-leak.patch b/keyboard-applet-leak.patch new file mode 100644 index 0000000..804a93f --- /dev/null +++ b/keyboard-applet-leak.patch @@ -0,0 +1,22 @@ +diff -up gnome-applets-2.23.90/gswitchit/gswitchit-applet.c.keyboard-applet-leak gnome-applets-2.23.90/gswitchit/gswitchit-applet.c +--- gnome-applets-2.23.90/gswitchit/gswitchit-applet.c.keyboard-applet-leak 2008-08-29 21:29:30.000000000 -0400 ++++ gnome-applets-2.23.90/gswitchit/gswitchit-applet.c 2008-08-29 21:29:34.000000000 -0400 +@@ -151,14 +151,17 @@ GSwitchItAppletSetBackground (PanelApple + + /* go down */ + if (GTK_IS_CONTAINER (w)) { +- GList *child = ++ GList *child; ++ GList *children = + gtk_container_get_children (GTK_CONTAINER (w)); ++ child = children; + while (child != NULL) { + GSwitchItAppletSetBackground (applet, + GTK_WIDGET (child-> + data)); + child = child->next; + } ++ g_list_free (children); + } + } +