PR#2: Move .so to -devel, hardcode soname - rpms/fsverity-utils

Colin Walters • 3 years ago

fd013da

fsverity-utils.spec

file modified

+6 -2

		`@@ -1,6 +1,6 @@`
		`Name: fsverity-utils`
		`Version: 1.1`
		`- Release: 1%{?dist}`
		`+ Release: 2%{?dist}`
		`Summary: fsverity utilities`

		`License: BSD`
		`@@ -42,14 +42,18 @@`
		`%doc README.md`
		`%license COPYING`
		`%{_bindir}/fsverity`
		`- %{_libdir}/.so`
		`+ %{_libdir}/*.so.0`


		`%files devel`
		`%{_includedir}/*`
		`%{_libdir}/*.a`
		`+ %{_libdir}/*.so`

		`%changelog`
		`+ * Mon Jun 15 2020 Colin Walters <walters@verbum.org> - 1.1-2`
		`+ - Move .so to -devel, hardcode soname`
		`+`
		`* Mon Jun 15 2020 Jes Sorensen <Jes.Sorensen@gmail.com> - 1.1-1`
		`- Update to version 1.1, split into fsverity-utils and fsverity-utils-devel`

no initial comment

rebased onto fd013da

3 years ago

OK this looks fine, but I just noticed a bug in the .spec I provided :(

It needs to build with USE_SHARED_LIB=1, but it looks like that isn't actually passed to the Makefile the way I did it.

We can also leave the fsverity binary statically linked, not a huge deal I guess.

Let me know if you need anything else from me to merge this.

It needs to build with USE_SHARED_LIB=1, but it looks like that isn't actually passed to the Makefile the way I did it.

I just debugged this, we also need to pass it to make install which is arguably an upstream build system bug but eh.

It needs to build with USE_SHARED_LIB=1, but it looks like that isn't actually passed to the Makefile the way I did it.

I just debugged this, we also need to pass it to make install which is arguably an upstream build system bug but eh.

Pull-Request has been merged by walters

3 years ago

Assignee

None

Tags

No Tags