Blame 0003-disable-eigrp-crypto.patch

1924a87
diff --git a/eigrpd/eigrp_packet.c b/eigrpd/eigrp_packet.c
1924a87
index bedaf15..8dc09bf 100644
1924a87
--- a/eigrpd/eigrp_packet.c
1924a87
+++ b/eigrpd/eigrp_packet.c
1924a87
@@ -40,8 +40,10 @@
1924a87
 #include "log.h"
1924a87
 #include "sockopt.h"
1924a87
 #include "checksum.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
 #include "sha256.h"
1924a87
+#endif
1924a87
 #include "lib_errors.h"
1924a87
 
1924a87
 #include "eigrpd/eigrp_structs.h"
1924a87
@@ -95,8 +97,12 @@ int eigrp_make_md5_digest(struct eigrp_interface *ei, struct stream *s,
1924a87
 	struct key *key = NULL;
1924a87
 	struct keychain *keychain;
1924a87
 
1924a87
+
1924a87
 	unsigned char digest[EIGRP_AUTH_TYPE_MD5_LEN];
1924a87
+#ifdef CRYPTO_OPENSSL
1924a87
+#elif CRYPTO_INTERNAL
1924a87
 	MD5_CTX ctx;
1924a87
+#endif
1924a87
 	uint8_t *ibuf;
1924a87
 	size_t backup_get, backup_end;
1924a87
 	struct TLV_MD5_Authentication_Type *auth_TLV;
1924a87
@@ -119,6 +125,9 @@ int eigrp_make_md5_digest(struct eigrp_interface *ei, struct stream *s,
1924a87
 		return EIGRP_AUTH_TYPE_NONE;
1924a87
 	}
1924a87
 
1924a87
+#ifdef CRYPTO_OPENSSL
1924a87
+//TBD when this is fixed in upstream
1924a87
+#elif CRYPTO_INTERNAL
1924a87
 	memset(&ctx, 0, sizeof(ctx));
1924a87
 	MD5Init(&ctx;;
1924a87
 
1924a87
@@ -146,7 +155,7 @@ int eigrp_make_md5_digest(struct eigrp_interface *ei, struct stream *s,
1924a87
 	}
1924a87
 
1924a87
 	MD5Final(digest, &ctx;;
1924a87
-
1924a87
+#endif
1924a87
 	/* Append md5 digest to the end of the stream. */
1924a87
 	memcpy(auth_TLV->digest, digest, EIGRP_AUTH_TYPE_MD5_LEN);
1924a87
 
1924a87
@@ -162,7 +171,10 @@ int eigrp_check_md5_digest(struct stream *s,
1924a87
 			   struct TLV_MD5_Authentication_Type *authTLV,
1924a87
 			   struct eigrp_neighbor *nbr, uint8_t flags)
1924a87
 {
1924a87
+#ifdef CRYPTO_OPENSSL
1924a87
+#elif CRYPTO_INTERNAL
1924a87
 	MD5_CTX ctx;
1924a87
+#endif
1924a87
 	unsigned char digest[EIGRP_AUTH_TYPE_MD5_LEN];
1924a87
 	unsigned char orig[EIGRP_AUTH_TYPE_MD5_LEN];
1924a87
 	struct key *key = NULL;
1924a87
@@ -203,6 +215,9 @@ int eigrp_check_md5_digest(struct stream *s,
1924a87
 		return 0;
1924a87
 	}
1924a87
 
1924a87
+#ifdef CRYPTO_OPENSSL
1924a87
+	//TBD when eigrpd crypto is fixed in upstream
1924a87
+#elif CRYPTO_INTERNAL
1924a87
 	memset(&ctx, 0, sizeof(ctx));
1924a87
 	MD5Init(&ctx;;
1924a87
 
1924a87
@@ -230,6 +245,7 @@ int eigrp_check_md5_digest(struct stream *s,
1924a87
 	}
1924a87
 
1924a87
 	MD5Final(digest, &ctx;;
1924a87
+#endif
1924a87
 
1924a87
 	/* compare the two */
1924a87
 	if (memcmp(orig, digest, EIGRP_AUTH_TYPE_MD5_LEN) != 0) {
1924a87
@@ -254,7 +270,11 @@ int eigrp_make_sha256_digest(struct eigrp_interface *ei, struct stream *s,
1924a87
 	unsigned char digest[EIGRP_AUTH_TYPE_SHA256_LEN];
1924a87
 	unsigned char buffer[1 + PLAINTEXT_LENGTH + 45 + 1] = {0};
1924a87
 
1924a87
+#ifdef CRYPTO_OPENSSL
1924a87
+	//TBD when eigrpd crypto is fixed in upstream
1924a87
+#elif CRYPTO_INTERNAL
1924a87
 	HMAC_SHA256_CTX ctx;
1924a87
+#endif
1924a87
 	void *ibuf;
1924a87
 	size_t backup_get, backup_end;
1924a87
 	struct TLV_SHA256_Authentication_Type *auth_TLV;
1924a87
@@ -283,6 +303,9 @@ int eigrp_make_sha256_digest(struct eigrp_interface *ei, struct stream *s,
1924a87
 
1924a87
 	inet_ntop(AF_INET, &ei->address.u.prefix4, source_ip, PREFIX_STRLEN);
1924a87
 
1924a87
+#ifdef CRYPTO_OPENSSL
1924a87
+	//TBD when eigrpd crypto is fixed in upstream
1924a87
+#elif CRYPTO_INTERNAL
1924a87
 	memset(&ctx, 0, sizeof(ctx));
1924a87
 	buffer[0] = '\n';
1924a87
 	memcpy(buffer + 1, key, strlen(key->string));
1924a87
@@ -291,7 +314,7 @@ int eigrp_make_sha256_digest(struct eigrp_interface *ei, struct stream *s,
1924a87
 			  1 + strlen(key->string) + strlen(source_ip));
1924a87
 	HMAC__SHA256_Update(&ctx, ibuf, strlen(ibuf));
1924a87
 	HMAC__SHA256_Final(digest, &ctx;;
1924a87
-
1924a87
+#endif
1924a87
 
1924a87
 	/* Put hmac-sha256 digest to it's place */
1924a87
 	memcpy(auth_TLV->digest, digest, EIGRP_AUTH_TYPE_SHA256_LEN);
1924a87
diff --git a/eigrpd/eigrp_filter.c b/eigrpd/eigrp_filter.c
1924a87
index 93eed94..f1c7347 100644
1924a87
--- a/eigrpd/eigrp_filter.c
1924a87
+++ b/eigrpd/eigrp_filter.c
1924a87
@@ -47,7 +47,9 @@
1924a87
 #include "if_rmap.h"
1924a87
 #include "plist.h"
1924a87
 #include "distribute.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
+#endif
1924a87
 #include "keychain.h"
1924a87
 #include "privs.h"
1924a87
 #include "vrf.h"
1924a87
diff --git a/eigrpd/eigrp_hello.c b/eigrpd/eigrp_hello.c
1924a87
index dacd5ca..b232cc5 100644
1924a87
--- a/eigrpd/eigrp_hello.c
1924a87
+++ b/eigrpd/eigrp_hello.c
1924a87
@@ -43,7 +43,9 @@
1924a87
 #include "sockopt.h"
1924a87
 #include "checksum.h"
1924a87
 #include "vty.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
+#endif
1924a87
 
1924a87
 #include "eigrpd/eigrp_structs.h"
1924a87
 #include "eigrpd/eigrpd.h"
1924a87
diff --git a/eigrpd/eigrp_query.c b/eigrpd/eigrp_query.c
1924a87
index 84dcf5e..a2575e3 100644
1924a87
--- a/eigrpd/eigrp_query.c
1924a87
+++ b/eigrpd/eigrp_query.c
1924a87
@@ -38,7 +38,9 @@
1924a87
 #include "log.h"
1924a87
 #include "sockopt.h"
1924a87
 #include "checksum.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
+#endif
1924a87
 #include "vty.h"
1924a87
 
1924a87
 #include "eigrpd/eigrp_structs.h"
1924a87
diff --git a/eigrpd/eigrp_reply.c b/eigrpd/eigrp_reply.c
1924a87
index ccf0496..2902365 100644
1924a87
--- a/eigrpd/eigrp_reply.c
1924a87
+++ b/eigrpd/eigrp_reply.c
1924a87
@@ -42,7 +42,9 @@
1924a87
 #include "log.h"
1924a87
 #include "sockopt.h"
1924a87
 #include "checksum.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
+#endif
1924a87
 #include "vty.h"
1924a87
 #include "keychain.h"
1924a87
 #include "plist.h"
1924a87
diff --git a/eigrpd/eigrp_siaquery.c b/eigrpd/eigrp_siaquery.c
1924a87
index ff38325..09b9369 100644
1924a87
--- a/eigrpd/eigrp_siaquery.c
1924a87
+++ b/eigrpd/eigrp_siaquery.c
1924a87
@@ -38,7 +38,9 @@
1924a87
 #include "log.h"
1924a87
 #include "sockopt.h"
1924a87
 #include "checksum.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
+#endif
1924a87
 #include "vty.h"
1924a87
 
1924a87
 #include "eigrpd/eigrp_structs.h"
1924a87
diff --git a/eigrpd/eigrp_siareply.c b/eigrpd/eigrp_siareply.c
1924a87
index d3dd123..f6a2bd6 100644
1924a87
--- a/eigrpd/eigrp_siareply.c
1924a87
+++ b/eigrpd/eigrp_siareply.c
1924a87
@@ -37,7 +37,9 @@
1924a87
 #include "log.h"
1924a87
 #include "sockopt.h"
1924a87
 #include "checksum.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
+#endif
1924a87
 #include "vty.h"
1924a87
 
1924a87
 #include "eigrpd/eigrp_structs.h"
1924a87
diff --git a/eigrpd/eigrp_snmp.c b/eigrpd/eigrp_snmp.c
1924a87
index 21c9238..cfb8890 100644
1924a87
--- a/eigrpd/eigrp_snmp.c
1924a87
+++ b/eigrpd/eigrp_snmp.c
1924a87
@@ -42,7 +42,9 @@
1924a87
 #include "log.h"
1924a87
 #include "sockopt.h"
1924a87
 #include "checksum.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
+#endif
1924a87
 #include "keychain.h"
1924a87
 #include "smux.h"
1924a87
 
1924a87
diff --git a/eigrpd/eigrp_update.c b/eigrpd/eigrp_update.c
1924a87
index 8db4903..2a4f0bb 100644
1924a87
--- a/eigrpd/eigrp_update.c
1924a87
+++ b/eigrpd/eigrp_update.c
1924a87
@@ -42,7 +42,9 @@
1924a87
 #include "log.h"
1924a87
 #include "sockopt.h"
1924a87
 #include "checksum.h"
1924a87
+#ifdef CRYPTO_INTERNAL
1924a87
 #include "md5.h"
1924a87
+#endif
1924a87
 #include "vty.h"
1924a87
 #include "plist.h"
1924a87
 #include "plist_int.h"
55a1dda
diff --git a/eigrpd/eigrp_cli.c b/eigrpd/eigrp_cli.c
55a1dda
index a93d4c8..b01e121 100644
55a1dda
--- a/eigrpd/eigrp_cli.c
55a1dda
+++ b/eigrpd/eigrp_cli.c
55a1dda
@@ -25,6 +25,7 @@
55a1dda
 #include "lib/command.h"
55a1dda
 #include "lib/log.h"
55a1dda
 #include "lib/northbound_cli.h"
55a1dda
+#include "lib/libfrr.h"
55a1dda
 
55a1dda
 #include "eigrp_structs.h"
55a1dda
 #include "eigrpd.h"
55a1dda
@@ -726,6 +726,20 @@ DEFPY(
55a1dda
 	"Keyed message digest\n"
55a1dda
 	"HMAC SHA256 algorithm \n")
55a1dda
 {
55a1dda
+	//EIGRP authentication is currently broken in FRR
55a1dda
+	switch (frr_get_cli_mode()) {
55a1dda
+	case FRR_CLI_CLASSIC:
55a1dda
+		vty_out(vty, "%% Eigrp Authentication is disabled\n\n");
55a1dda
+		break;
55a1dda
+	case FRR_CLI_TRANSACTIONAL:
55a1dda
+		vty_out(vty,
55a1dda
+			"%% Failed to edit candidate configuration - "
55a1dda
+			"Eigrp Authentication is disabled.\n\n");
55a1dda
+		break;
55a1dda
+	}
55a1dda
+
55a1dda
+	return CMD_WARNING_CONFIG_FAILED;
55a1dda
+
55a1dda
 	char xpath[XPATH_MAXLEN], xpath_auth[XPATH_MAXLEN + 64];
55a1dda
 
55a1dda
 	snprintf(xpath, sizeof(xpath), "./frr-eigrpd:eigrp/instance[asn='%s']",