#1 Fix libmodulemd dependency
Merged 4 years ago by nphilipp. Opened 4 years ago by sgallagh.
rpms/ sgallagh/fedmod master  into  master

file modified
+6 -3
@@ -2,7 +2,7 @@ 

  

  Name:           fedmod

  Version:        0.6.3

- Release:        2%{?dist}

+ Release:        3%{?dist}

  Summary:        Utilities for generating & maintaining modulemd files

  

  License:        GPLv2+ and GPLv3+ and MIT
@@ -10,7 +10,6 @@ 

  Source0:        %{name}-%{version}.tar.gz

  BuildArch:      noarch

  

- BuildRequires:  libmodulemd >= 1.6.2

  BuildRequires:  python3-aiohttp

  BuildRequires:  python3-attrs

  BuildRequires:  python3-click
@@ -20,6 +19,7 @@ 

  BuildRequires:  python3-dnf

  BuildRequires:  python3-gobject-base

  BuildRequires:  python3-koji

+ BuildRequires:  python3-libmodulemd1 >= 1.6.2

  BuildRequires:  python3-lxml

  BuildRequires:  python3-pytest

  BuildRequires:  python3-PyYAML
@@ -29,13 +29,13 @@ 

  BuildRequires:  python3-smartcols

  BuildRequires:  python3-solv

  

- Requires:       libmodulemd >= 1.6.2

  Requires:       python3-aiohttp

  Requires:       python3-attrs

  Requires:       python3-click

  Requires:       python3-click-completion

  Requires:       python3-gobject-base

  Requires:       python3-koji

+ Requires:       python3-libmodulemd1 >= 1.6.2

  Requires:       python3-lxml

  Requires:       python3-PyYAML

  Requires:       python3-requests
@@ -109,6 +109,9 @@ 

  %{_datadir}/fish/vendor_completions.d/fedmod.fish

  

  %changelog

+ * Wed Jul 31 2019 Stephen Gallagher <sgallagh@redhat.com> - 0.6.3-3

+ - Fix libmodulemd dependency

+ 

  * Thu Jul 25 2019 Fedora Release Engineering <releng@fedoraproject.org> - 0.6.3-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild

  

Currently, this is probably working by coincidence because most installations happen to have libmodulemd1 on it as a dependency of libdnf, but we should fix the dependency so that if that changes fedmod won't break.

Signed-off-by: Stephen Gallagher sgallagh@redhat.com

To clarify: the current way that the dependency is specified would be satisfied by libmodulemd 2.x which fedmod is not compatible with. It only works because libmodulemd1 is also on the system and they are parallel-installable.

Looks good to me, thanks!

Pull-Request has been merged by nphilipp

4 years ago
Metadata