|
 |
2854df3 |
From 9f9a3ded23cc2bb917468939b745cc498cec523a Mon Sep 17 00:00:00 2001
|
|
|
2854df3 |
From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzidek@redhat.com>
|
|
|
2854df3 |
Date: Wed, 1 Aug 2018 17:48:10 +0200
|
|
|
2854df3 |
Subject: [PATCH] validators_ut_check: Fix fail with new glibc
|
|
|
2854df3 |
|
|
|
2854df3 |
Error message was slightly change from previous version
|
|
|
2854df3 |
of glibc which caused fails in validators unit tests.
|
|
|
2854df3 |
|
|
|
2854df3 |
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
|
|
|
2854df3 |
---
|
|
|
2854df3 |
ini/ini_validators_ut_check.c | 13 +++++++++++--
|
|
|
2854df3 |
1 file changed, 11 insertions(+), 2 deletions(-)
|
|
|
2854df3 |
|
|
|
2854df3 |
diff --git a/ini/ini_validators_ut_check.c b/ini/ini_validators_ut_check.c
|
|
|
2854df3 |
index 9ecde75..3af8551 100644
|
|
|
2854df3 |
--- a/ini/ini_validators_ut_check.c
|
|
|
2854df3 |
+++ b/ini/ini_validators_ut_check.c
|
|
|
2854df3 |
@@ -602,6 +602,8 @@ START_TEST(test_ini_allowed_options_wrong_regex)
|
|
|
2854df3 |
fail_unless(ret == 0, "Got msg: [%s]", errmsg);
|
|
|
2854df3 |
ini_errobj_next(errobj);
|
|
|
2854df3 |
|
|
|
2854df3 |
+ /* Different versions of libc produce slightly different error strings
|
|
|
2854df3 |
+ * in this case. For simplicity compare against all of them. */
|
|
|
2854df3 |
errmsg = ini_errobj_get_msg(errobj);
|
|
|
2854df3 |
ret = strcmp(errmsg,
|
|
|
2854df3 |
"[rule/options_for_foo]: Cannot compile regular expression "
|
|
|
2854df3 |
@@ -609,10 +611,17 @@ START_TEST(test_ini_allowed_options_wrong_regex)
|
|
|
2854df3 |
"Error: 'Unmatched [ or [^'");
|
|
|
2854df3 |
if (ret != 0) {
|
|
|
2854df3 |
ret = strcmp(errmsg,
|
|
|
2854df3 |
- "[rule/options_for_foo]: Cannot compile regular expression "
|
|
|
2854df3 |
- "from option 'section_re'. "
|
|
|
2854df3 |
+ "[rule/options_for_foo]: Cannot compile regular "
|
|
|
2854df3 |
+ "expression from option 'section_re'. "
|
|
|
2854df3 |
"Error: 'brackets ([ ]) not balanced'");
|
|
|
2854df3 |
}
|
|
|
2854df3 |
+
|
|
|
2854df3 |
+ if (ret != 0) {
|
|
|
2854df3 |
+ ret = strcmp(errmsg,
|
|
|
2854df3 |
+ "[rule/options_for_foo]: Cannot compile regular "
|
|
|
2854df3 |
+ "expression from option 'section_re'. "
|
|
|
2854df3 |
+ "Error: 'Unmatched [, [^, [:, [., or [='");
|
|
|
2854df3 |
+ }
|
|
|
2854df3 |
fail_unless(ret == 0, "Got msg: [%s]", errmsg);
|
|
|
2854df3 |
ini_errobj_next(errobj);
|
|
|
2854df3 |
|
|
|
2854df3 |
--
|
|
|
2854df3 |
2.9.5
|
|
|
2854df3 |
|