|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
From c98bc4b769f85da3199485c85e8c98bb8c87ff04 Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
From: mike <mike@7a7537e8-13f0-0310-91df-b6672ffda945>
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
Date: Tue, 9 Oct 2012 03:01:31 +0000
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
Subject: [PATCH] Work around broken 1284 device IDs that use a newline
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
instead of a semicolon.
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
git-svn-id: http://svn.easysw.com/public/cups/trunk@10642 7a7537e8-13f0-0310-91df-b6672ffda945
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
---
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
diff --git a/backend/snmp.c b/backend/snmp.c
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
index f672e37..fc40800 100644
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
--- a/backend/snmp.c
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+++ b/backend/snmp.c
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
@@ -1025,6 +1025,11 @@ read_snmp_response(int fd) /* I - SNMP socket file descriptor */
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
* Description is the IEEE-1284 device ID...
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
*/
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+ char *ptr; /* Pointer into device ID */
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+ for (ptr = (char *)packet.object_value.string.bytes; *ptr; ptr ++)
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+ if (*ptr == '\n')
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+ *ptr = ';'; /* A lot of bad printers put a newline */
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
if (!device->id)
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
device->id = strdup((char *)packet.object_value.string.bytes);
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
@@ -1066,8 +1071,11 @@ read_snmp_response(int fd) /* I - SNMP socket file descriptor */
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
*/
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
char make_model[256]; /* Make and model */
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+ char *ptr; /* Pointer into device ID */
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
-
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+ for (ptr = (char *)packet.object_value.string.bytes; *ptr; ptr ++)
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+ if (*ptr == '\n')
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
+ *ptr = ';'; /* A lot of bad printers put a newline */
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
if (device->id)
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
free(device->id);
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
--
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
1.7.11.7
|
|
![](https://seccdn.libravatar.org/avatar/ea65bbbf308b4e40b533a7d82d44d78439b3dfed89f97118a80e7f7e69cb92d8?s=16&d=retro) |
11a862d |
|